You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/24 09:58:54 UTC

[GitHub] [zookeeper] fviernau opened a new pull request #1465: pom.xml: Fix-up the packaging type

fviernau opened a new pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465


   Since there is a `zookeeper.jar` artifact corresponding to this POM file
   published, the packaging should be set to "jar".
   
   Signed-off-by: Frank Viernau <fr...@here.com>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ctubbsii commented on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698395502


   I recommend marking this issue with the label `invalid` and closing it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] fviernau commented on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
fviernau commented on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698421464






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] fviernau closed pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
fviernau closed pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] fviernau commented on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
fviernau commented on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698421464


   @ctubbsii @eolivelli , right - it seems I did the wrong thing. Anyhow, I stumbled across this when viewing [1]. 
   That one should be incorrect, shouldn't it? If so, mind giving a hint if the problem still exists in master?
   
   [1] https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.6/zookeeper-3.4.6.pom


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] fviernau commented on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
fviernau commented on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698428729


   Thanks @eolivelli! So no point in keeping this open.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] ctubbsii commented on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698395502


   I recommend marking this issue with the label `invalid` and closing it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] fviernau closed pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
fviernau closed pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] eolivelli commented on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698423751


   ZooKeeper 3.4.6 was build with Ant and Maven artifacts where created from a a template.
   
   On Master branch the layout of the repository is far different.
   On branch 3.4 probably we tried to move to Maven but we never cut a release and 3.4 release is EOL so there is no need to spend time on that branch.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] fviernau edited a comment on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
fviernau edited a comment on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698421464


   @ctubbsii @eolivelli , right - it seems I did the wrong thing. Anyhow, I stumbled across this when viewing [1]. 
   That one should be incorrect, shouldn't it (because it has a jar file)? If so, mind giving a hint if the problem still exists in master?
   
   [1] https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.6/zookeeper-3.4.6.pom


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] fviernau edited a comment on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
fviernau edited a comment on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698421464


   @ctubbsii @eolivelli , right - it seems I did the wrong thing. Anyhow, I stumbled across this when viewing [1]. 
   That one should be incorrect, shouldn't it (because it has a jar file)? If so, mind giving a hint if the problem still exists in master?
   
   [1] https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.6/zookeeper-3.4.6.pom


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] eolivelli commented on pull request #1465: pom.xml: Fix-up the packaging type

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1465:
URL: https://github.com/apache/zookeeper/pull/1465#issuecomment-698423751


   ZooKeeper 3.4.6 was build with Ant and Maven artifacts where created from a a template.
   
   On Master branch the layout of the repository is far different.
   On branch 3.4 probably we tried to move to Maven but we never cut a release and 3.4 release is EOL so there is no need to spend time on that branch.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org