You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/31 03:05:38 UTC

[GitHub] [calcite] yanlin-Lynn commented on issue #1301: [CALCITE-3175] AssertionError during serializing RexLiteral with Enum type.

yanlin-Lynn commented on issue #1301: [CALCITE-3175] AssertionError during serializing RexLiteral with Enum type.
URL: https://github.com/apache/calcite/pull/1301#issuecomment-516675210
 
 
   > I didn't like the idea of putting class names in JSON, so I came up with an alternative. If the type of a literal in JSON is "SYMBOL", then it looks up the enum constant among a list of registered enum classes.
   > 
   > This takes advantage of the fact that there is a small, fixed number of enum classes that can appear in a RelNode tree, and their constant names (up til now, anyway) are unique.
   > 
   > Please review https://github.com/julianhyde/calcite/tree/3175-rel-json-enum and let me know what you think.
   
   I'm OK with the alternative way, seems more reasonable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services