You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/09/17 07:49:15 UTC

[GitHub] [ratis] szetszwo opened a new pull request, #749: RATIS-1710. Refactor metrics api and implementation to separated modules.

szetszwo opened a new pull request, #749:
URL: https://github.com/apache/ratis/pull/749

   See https://issues.apache.org/jira/browse/RATIS-1710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] szetszwo commented on pull request #749: RATIS-1710. Refactor metrics api and implementation to separated modules.

Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #749:
URL: https://github.com/apache/ratis/pull/749#issuecomment-1254847336

   > ... since the ratis-metrics module is empty now, shouldn't we just remove it.
   
   When a directory is empty, git will automatically remove it.  For example,   the ratis-metrics module is not in https://github.com/apache/ratis anymore.  For the local copies, we may need to remove it manually since there probably is a `target` directory or some other Ide files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] szetszwo commented on pull request #749: RATIS-1710. Refactor metrics api and implementation to separated modules.

Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #749:
URL: https://github.com/apache/ratis/pull/749#issuecomment-1253744101

   @codings-dan , thanks a lot for reviewing this!
   
   > BTW, should we just remove the ratis-metrics module directly?
   
   Do you mean we should not rename `ratis-metrics` to `ratis-metrics-api` and keep using the name `ratis-metrics`?  I thought about it -- since the API has changed, it probably will have more confusion if we keep using `ratis-metrics`.  The applications has to update the code anyway.   Using also the module name is not a big deal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] szetszwo merged pull request #749: RATIS-1710. Refactor metrics api and implementation to separated modules.

Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #749:
URL: https://github.com/apache/ratis/pull/749


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] codings-dan commented on pull request #749: RATIS-1710. Refactor metrics api and implementation to separated modules.

Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #749:
URL: https://github.com/apache/ratis/pull/749#issuecomment-1254780575

   > @codings-dan , thanks a lot for reviewing this!
   > 
   > > BTW, should we just remove the ratis-metrics module directly?
   > 
   > Do you mean we should not rename `ratis-metrics` to `ratis-metrics-api` and keep using the name `ratis-metrics`? I thought about it -- since the API has changed, it probably will have more confusion if we keep using `ratis-metrics`. The applications has to update the code anyway. Using also the module name is not a big deal.
   
   Change the name is fine. I mean, since the `ratis-metrics` module is empty now, shouldn't we just remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ratis] codings-dan commented on pull request #749: RATIS-1710. Refactor metrics api and implementation to separated modules.

Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #749:
URL: https://github.com/apache/ratis/pull/749#issuecomment-1255732419

   > When a directory is empty, git will automatically remove it.
   
   I didn't know that git can be automatically remove empty dir,  thank you for telling me! Now `ratis-metrics` is indeed not in [ratis](https://github.com/apache/ratis)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org