[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r308201572
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java
 ##########
 @@ -220,4 +221,510 @@ public void testReadRepeatedDecimals() throws Exception {
         .baselineValues(ints, longs, fixedLen, fixedLen)
         .go();
   }
+
+  @Test
 
 Review comment:
   @KazydubB I see only unit tests for Parquet. Please add tests for  other formats in Drill that support maps. For example Avro: https://avro.apache.org/docs/current/spec.html#Maps
   
   Also please adds tests to check that maps are written correctly for Parquet and Avro.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services