[GitHub] [incubator-mxnet] sxjscience edited a comment on issue #19073: Multinomial sampling produces impossible values

[GitBox <gi...@apache.org>]

sxjscience edited a comment on issue #19073:
URL: https://github.com/apache/incubator-mxnet/issues/19073#issuecomment-723237552


   @bricksdont The binary search here does not seem to be correct: https://github.com/apache/incubator-mxnet/blob/9d440868603ad26b702e12ddd2587e5c4b56e42b/src/operator/random/sample_multinomial_op.h#L128-L143
   
   We may choose to directly use the discrete distribution in std c++ http://www.cplusplus.com/reference/random/discrete_distribution/ or use the std functions for binary search.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org