You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/09/24 11:27:58 UTC

[GitHub] [zeppelin] martin-g opened a new pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

martin-g opened a new pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233


   ### What is this PR for?
   
   Update protoc and grpc to their first versions that support Linux ARM64 architecture.
   With this the build on Linux ARM64 passes!
   
   ### What type of PR is it?
   Bug Fix
   
   ### What is the Jira issue?
   
   [ZEPPELIN-5536](https://issues.apache.org/jira/browse/ZEPPELIN-5536)
   
   ### How should this be tested?
   
   Run the build on Linux ARM64, e.g. at TravisCI or even better CircleCI on ARM64 hardware! 
   Let me know if you want me to setup either of those!
   
   ### Questions:
   * Does the licenses files need update? - NO
   * Is there breaking changes for older versions? - Hopefully not! There is one API break in Grpc APIs (`usePlaintext()`), but there might be problems in reading serialized messages with the old versions 
   * Does this needs documentation? - NO
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927229606


   Thanks @martin-g for the investigation, I checked CircleCI. But it seems not free like github action. We have to think about other options. It would be done in another PR. Regarding this PR, LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927348092


   > But it seems not free like github action.
   
   CircleCI is free for public repos.
   And resource type `arm64.medium` is free. `arm4.large` is paid though!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] jongyoul commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927016213


   > I could try to replace it with headless Chromium! I'll keep you posted!
   
   Sounds like a great idea!! Thank you!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g edited a comment on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-926555195


   Actually the build passes only if I disable the tests for the web app module, because they use PhantomJS which has no binary for Linux aarch64, and since PhantomJS is a dead project it will never have such officially.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] jongyoul commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-926603705


   @martin-g Hello, I might not understand what you are saying but could you please explain more about PhantomJS and the result of this CI? It looks like all passed without disabling anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] asfgit closed pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927581847


   Thanks @martin-g I will merge this PR if no more comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927580944


   @zjffdu I will prepare a PR for testing on Linux ARM64 at CircleCI!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927348243


   > Sounds like a great idea!! Thank you!!
   
   @jongyoul I will work on it in a separate PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-926555195


   Actually the build passes only if I disable the test for the web app module, because they use PhantomJS which has no binary for Linux aarch64, and since PhantomJS is a dead project it will never have such officially.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g edited a comment on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927348092


   > But it seems not free like github action.
   
   CircleCI is free for public repos.
   And resource type `arm64.medium` is free. `arm64.large` is paid though!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] jongyoul edited a comment on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
jongyoul edited a comment on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-926653501


   @martin-g Thank you for explaining it. I also think `PhantomJS` is quite old but we don't have many resources to fix/improve it. Do you have any idea to improve it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-926966809


   @martin-g Do you know whether GitHub Actions support ARM64 ? If so, we should enable it to avoid regression. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] jongyoul commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-926653501


   @martin-g Thank you for explaining it. I also think PhantomJS is quite old but we don't have many resources to fix/improve it. Do you have any idea to improve it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] asfgit closed pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-926638067


   The CI passed because GitHub Actions run on x86_64 machines. 
   This PR is about improving the situation on Linux aarch64 (ARM64).
   Officially PhantomJS provides only x86_64 binaries. Trying to `npm install phantomjs` on non-x86_64 would fail.
   Since PhantomJS is not maintained since few years some projects have replaced it with headless chrome/chromium.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927519517


   > CircleCI is free for public repos
   
   ha, right, CircleCI has free plan for open source project. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu edited a comment on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927229606


   Thanks @martin-g for the investigation, I checked CircleCI. But it seems not free like github action. We have to think about other options. It could be done in another PR future. Regarding this PR, LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927017014


   > Do you know whether GitHub Actions support ARM64 ? If so, we should enable it to avoid regression.
   
   GitHub Actions does not provide Linux ARM64 VMs at the moment (https://github.com/actions/virtual-environments/issues/2536).
   But there are few ways to do it:
   * self-hosted runner - There are security concerns with it!  GHA does not recommend using self-hosted runners for public repositories. Apache AirFlow uses custom GHA runner with better security. If you go this way then using [Oracle Cloud ARM64](https://blogs.oracle.com/cloud-infrastructure/post/announcing-github-actions-arm-runners-for-the-arm-compute-platform-on-oracle-cloud-infrastructure) for the runner is very easy! 
   * Remote Kubernetes - I have blogged about it [here](https://martin-grigorov.medium.com/githubactions-build-and-test-on-huaweicloud-arm64-af9d5c97b766). The issue here is that the setup becomes a bit more complex
   
   Other projects use TravisCI or CircleCI (my recommendation) for testing on Linux ARM64/PPC64/s390x. The issue is - one more CI to maintain and watch over.
   Yet another option is to use Apache Jenkins or Buildbot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] martin-g commented on pull request #4233: ZEPPELIN-5536 Update protoc and grpc for Linux ARM64

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4233:
URL: https://github.com/apache/zeppelin/pull/4233#issuecomment-927016049


   > Thank you for explaining it. I also think `PhantomJS` is quite old but we don't have many resources to fix/improve it. Do you have any idea to improve it?
   
   I could try to replace it with headless Chromium! I'll keep you posted!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org