[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6776: Spark 3.3: Improve log messages in scans

["amogh-jahagirdar (via GitHub)" <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #6776:
URL: https://github.com/apache/iceberg/pull/6776#discussion_r1100787732


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -140,7 +140,7 @@ protected Statistics estimateStatistics(Snapshot snapshot) {
     // estimate stats using snapshot summary only for partitioned tables
     // (metadata tables are unpartitioned)
     if (!table.spec().isUnpartitioned() && filterExpressions.isEmpty()) {
-      LOG.debug("Using table metadata to estimate table statistics");
+      LOG.debug("Using snapshot metadata to estimate statistics for table {}", table.name());

Review Comment:
   Agreed, it'll help to log the snapshot here. With all the new time travel options being added (like branching and tagging), in case of any issues it'll be useful to be able to debug just by looking at the logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org