You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2016/06/08 11:46:20 UTC

[jira] [Updated] (OAK-4443) ExternalLoginModule: refactor to handle all reasons for 'ignore' together

     [ https://issues.apache.org/jira/browse/OAK-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated OAK-4443:
------------------------
    Attachment: OAK-4443.patch

> ExternalLoginModule: refactor to handle all reasons for 'ignore' together
> -------------------------------------------------------------------------
>
>                 Key: OAK-4443
>                 URL: https://issues.apache.org/jira/browse/OAK-4443
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: auth-external
>            Reporter: angela
>            Priority: Minor
>         Attachments: OAK-4443.patch
>
>
> while working on OAK-4417 i found {{ExternalLoginModule.login}} a bit hard to read... in particular the 3 reasons that prevent accessing the IDP are not handled together.
> the proposed patch slightly refactors {{ExternalLoginModule}}. [~tripod], maybe you want to take a quick look? otherwise i will go ahead and commit it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)