You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2010/03/10 23:45:39 UTC

svn commit: r921605 - /directory/shared/trunk/dsml-parser/src/main/java/org/apache/directory/shared/dsmlv2/engine/Dsmlv2Engine.java

Author: elecharny
Date: Wed Mar 10 22:45:39 2010
New Revision: 921605

URL: http://svn.apache.org/viewvc?rev=921605&view=rev
Log:
Fixed a potential NPE and removed dead code

Modified:
    directory/shared/trunk/dsml-parser/src/main/java/org/apache/directory/shared/dsmlv2/engine/Dsmlv2Engine.java

Modified: directory/shared/trunk/dsml-parser/src/main/java/org/apache/directory/shared/dsmlv2/engine/Dsmlv2Engine.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/dsml-parser/src/main/java/org/apache/directory/shared/dsmlv2/engine/Dsmlv2Engine.java?rev=921605&r1=921604&r2=921605&view=diff
==============================================================================
--- directory/shared/trunk/dsml-parser/src/main/java/org/apache/directory/shared/dsmlv2/engine/Dsmlv2Engine.java (original)
+++ directory/shared/trunk/dsml-parser/src/main/java/org/apache/directory/shared/dsmlv2/engine/Dsmlv2Engine.java Wed Mar 10 22:45:39 2010
@@ -399,17 +399,11 @@ public class Dsmlv2Engine
                 //     - O to n SearchResultReference
                 //     - 1 (only) SearchResultDone
                 // So we have to include those individual responses in a "General" SearchResponse
-                //            Element searchResponse = xmlResponse.getRootElement().addElement( "searchResponse" );
-                SearchResponseDsml searchResponseDsml = null; //new SearchResponseDsml();
+                SearchResponseDsml searchResponseDsml = null;
     
                 // RequestID
                 int requestID = response.getMessageId();
                 
-                if ( requestID != 0 )
-                {
-                    searchResponseDsml.setMessageId( requestID );
-                }
-    
                 while ( MessageTypeEnum.SEARCH_RESULT_DONE != response.getMessageType() )
                 {
                     if ( MessageTypeEnum.SEARCH_RESULT_ENTRY == response.getMessageType() )