[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3522: Python 3 upgrade

[GitBox <gi...@apache.org>]

joshfischer1108 commented on pull request #3522:
URL: https://github.com/apache/incubator-heron/pull/3522#issuecomment-636266189


   I did a local test on OSX by creating the install scripts.  So far it did not work as expected. I do think we are very close.  I installed Heron by the following:
   
   **Note:** All commands are ran from the root directory of the project
   ```
   $ bazel build --config=darwin_nostyle scripts/packages:binpkgs
   ````
   The above command's output is the install scripts. The location of the scripts will be echoed to the terminal.  Typically something like:
   ```
    Target //scripts/packages:binpkgs up-to-date:
     bazel-bin/scripts/packages/heron-install.sh
   ```
      I then installed them.
   ```
   $ ./bazel-bin/scripts/packages/heron-install.sh --user
   ```
   I checked the heron version command.  All good.
   ```
   $  heron version
   heron.build.git.revision : 1f80d5a20fbd146597de7dab3c94816a602239fd
   heron.build.git.status : Clean
   heron.build.host : Joshs-MacBook-Pro-2.local
   heron.build.time : Fri May 29 21:11:31 CDT 2020
   heron.build.timestamp : 1590804691000
   heron.build.user : joshfischer
   heron.build.version : python-3-upgrade
   ```
   Then I started the tracker.  All good.
   ```
   $ heron-tracker
   [2020-05-29 21:42:22 -0500] [INFO]: Connecting to file state with rootpath: /Users/joshfischer/.herondata/repository/state/local
   [2020-05-29 21:42:22 -0500] [INFO]: Tracker has started
   [2020-05-29 21:42:22 -0500] [INFO]: Running on port: 8888
   [2020-05-29 21:42:22 -0500] [INFO]: Using config file: /Users/joshfischer/.heron/conf/heron_tracker.yaml
   [2020-05-29 21:42:22 -0500] [INFO]: Using state manager:
   	type: file
   	name: local
   	rootpath: ~/.herondata/repository/state/local
   	tunnelhost: 127.0.0.1
   ```
   
   When trying to start the UI piece of Heron it looks like it could not find the `release.yaml` file.  See below:
   ```
   $ heron-ui
   Traceback (most recent call last):
     File ".bootstrap/pex/pex.py", line 396, in execute
     File ".bootstrap/pex/pex.py", line 328, in _wrap_coverage
     File ".bootstrap/pex/pex.py", line 359, in _wrap_profiling
     File ".bootstrap/pex/pex.py", line 447, in _execute
     File ".bootstrap/pex/pex.py", line 544, in execute_entry
     File ".bootstrap/pex/pex.py", line 551, in execute_module
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 208, in run_module
       return _run_code(code, {}, init_globals, run_name, mod_spec)
     File "/usr/local/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
       exec(code, run_globals)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/main.py", line 40, in <module>
       from heron.tools.ui.src.python import args
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/args.py", line 24, in <module>
       import heron.tools.ui.src.python.consts as consts
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/ui/src/python/consts.py", line 35, in <module>
       VERSION = common_config.get_version_number(zipped_pex=True)
     File "/Users/joshfischer/.pex/code/6e6aa1266ca563ae910c0bca80d652a68d3e9d94/heron/tools/common/src/python/utils/config.py", line 476, in get_version_number
       with open(release_file) as release_info:
   FileNotFoundError: [Errno 2] No such file or directory: '/Users/joshfischer/.heron/scripts/packages/release.yaml'
   ```
   However, the `release.yaml` is in the `~/.heron` directory.  Just not in that location.
   ```
   cd ~/.heron/
   bin/          dist/         examples/     lib/          
   conf/         etc/          include/      release.yaml 
   ```
   
   I may have to rebuild master and see if it expects the `release.yaml` to be in the same location.  Not sure yet. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org