[GitHub] [cloudstack] svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

[GitBox <gi...@apache.org>]

svenvogel commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-572776529
 
 
   Hi @weizhouapache,
   
   For me it’s now clear.
   
   One question from me. What I see is that all untagged offerings will be always as they are untagged assigned to the untagged one. Right? Tagged means I can use tags and fit the Network to the offer I want on the physical network.
   
   For me it’s an extension they don’t break anything. You are right! Normal admin will not affected because he can use only physical network untagged with all offerings without the need of an tag. But later if anyone get an more complex setup he need to edit the database and that’s always not an good idea.
   I think it is as you said if anyone has a more complex network like another rack or hybrid cloud he will need that.
   
   just by the way, now we could talk again about why is it so. Hey CS is a old lady and we don’t want to break things but we need to go forward, fix things, make them better and bring new features. This is like for me make them better.
   
   For me it’s an good solution if anyone gets an more complex setup but don’t want to edit the DB. This is always a no go. Normally ;)))
   
   
   __
   
   Sven Vogel
   Teamlead Platform
   
   EWERK DIGITAL GmbH
   Brühl 24, D-04109 Leipzig
   P +49 341 42649 - 99
   F +49 341 42649 - 98
   S.Vogel@ewerk.com
   www.ewerk.com
   
   Geschäftsführer:
   Dr. Erik Wende, Hendrik Schubert, Frank Richter
   Registergericht: Leipzig HRB 9065
   
   Support:
   +49 341 42649 555
   
   Zertifiziert nach:
   ISO/IEC 27001:2013
   DIN EN ISO 9001:2015
   DIN ISO/IEC 20000-1:2011
   
   ISAE 3402 Typ II Assessed
   
   EWERK-Blog<https://blog.ewerk.com/> | LinkedIn<https://www.linkedin.com/company/ewerk-group> | Xing<https://www.xing.com/company/ewerk> | Twitter<https://twitter.com/EWERK_Group> | Facebook<https://de-de.facebook.com/EWERK.IT/>
   
   Mit Handelsregistereintragung vom 09.07.2019 ist die EWERK RZ GmbH auf die EWERK IT GmbH verschmolzen und firmiert nun gemeinsam unter dem Namen: EWERK DIGITAL GmbH, für weitere Informationen klicken Sie hier<https://www.ewerk.com/ewerkdigital>.
   
   Auskünfte und Angebote per Mail sind freibleibend und unverbindlich.
   
   Disclaimer Privacy:
   Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. Vielen Dank.
   
   The contents of this e-mail (including any attachments) are confidential and may be legally privileged. If you are not the intended recipient of this e-mail, any disclosure, copying, distribution or use of its contents is strictly prohibited, and you should please notify the sender immediately and then delete it (including any attachments) from your system. Thank you.
   
   Am 09.01.2020 um 11:32 schrieb weizhouapache <no...@github.com>:
   
   
   
   @svenvogel<https://github.com/svenvogel> @andrijapanicsb<https://github.com/andrijapanicsb> @ravening<https://github.com/ravening>
   This PR aims the fix the issue in following scenario.
   
   Suppose we have a physical network (without tag, name=PUB) and some network offerings (without tag, eg name=Network-offering)
   
   Now, we want to add another physical network (PUB-NEW), and some network offerings (eg offering-NEW). To make it work, we have to tag all physical networks (PUB, PUB-NEW) and network offerings (Network-offering, Network-offering-NEW).
   
   With this patch, we only need to tag the new physical network (PUB-NEW) and new network offerings (eg Network-offering-NEW). We do NOT need to tag/change the existing physical network (PUB) and network offering (eg Network-offering). The networks created from network offering without tag will be allocated to the physical network without tag (it means, at most 1 physical network is not tagged).
   
   I hope it is clear.
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/3780?email_source=notifications&email_token=ABJOT5CQ7A4JJFZWCGT7CMTQ434JNA5CNFSM4J54HLTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIPZ4HI#issuecomment-572497437>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABJOT5HIK75WJGZ47FOYKL3Q434JNANCNFSM4J54HLTA>.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services