[GitHub] [spark] gengliangwang commented on a change in pull request #30292: [SPARK-33166][DOC] Provide Search Function in Spark docs site

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #30292:
URL: https://github.com/apache/spark/pull/30292#discussion_r520290288



##########
File path: docs/_layouts/global.html
##########
@@ -30,6 +30,8 @@
         <script src="js/vendor/modernizr-2.6.1-respond-1.1.0.min.js"></script>
 
         <link rel="stylesheet" href="css/pygments-default.css">
+        <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2/dist/cdn/docsearch.min.css" />

Review comment:
       For all the external css/js files for Spark UI/Doc, we always download it and make it as part of the source code.
   I think this is to make sure Spark UI/Doc can be run and access in a private network.
   However, it seems fine for Spark Doc. cc @srowen @sarutak , WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org