[GitHub] nlu90 commented on a change in pull request #2956: add integration test for instance state in stateful processing

[GitBox <gi...@apache.org>]

nlu90 commented on a change in pull request #2956: add integration test for instance state in stateful processing
URL: https://github.com/apache/incubator-heron/pull/2956#discussion_r201913036
 
 

 ##########
 File path: integration_test/src/java/org/apache/heron/integration_topology_test/common/AbstractTestTopology.java
 ##########
 @@ -82,12 +102,30 @@ public final void submit() throws AlreadyAliveException, InvalidTopologyExceptio
   }
 
   public final void submit(Config userConf) throws AlreadyAliveException, InvalidTopologyException {
-    TopologyBuilder builder = new TopologyBuilder();
-
-    Config conf = buildConfig(new BasicConfig());
-    if (userConf != null) {
-      conf.putAll(userConf);
+    if (this.httpServerResultsUrl == null) {
 
 Review comment:
   this `if ... else ...` clause shares several common code, let's reuse the duplicate part.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services