You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/02/17 08:18:31 UTC
[kudu-CR] WIP: java: fetch and adopt authn token and CA from master
Hello Dan Burkert, Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6054
to review the following change.
Change subject: WIP: java: fetch and adopt authn token and CA from master
......................................................................
WIP: java: fetch and adopt authn token and CA from master
This needs some automated testing. With manual testing I couldn't get
the token auth to kick in - not sure if it's an issue on the Java or C++
side yet. I do see that it's adopting a cert and token, though.
Change-Id: Idf172122f1c9152be9f954b26541499b714c440b
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java
2 files changed, 32 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/6054/1
--
To view, visit http://gerrit.cloudera.org:8080/6054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf172122f1c9152be9f954b26541499b714c440b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] WIP: java: fetch and adopt authn token and CA from master
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6054
to look at the new patch set (#2).
Change subject: WIP: java: fetch and adopt authn token and CA from master
......................................................................
WIP: java: fetch and adopt authn token and CA from master
This needs some automated testing. With manual testing I couldn't get
the token auth to kick in - not sure if it's an issue on the Java or C++
side yet. I do see that it's adopting a cert and token, though.
Change-Id: Idf172122f1c9152be9f954b26541499b714c440b
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
3 files changed, 77 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/6054/2
--
To view, visit http://gerrit.cloudera.org:8080/6054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf172122f1c9152be9f954b26541499b714c440b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP: java: fetch and adopt authn token and CA from master
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.
Change subject: WIP: java: fetch and adopt authn token and CA from master
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/6054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Idf172122f1c9152be9f954b26541499b714c440b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP: java: fetch and adopt authn token and CA from master
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: WIP: java: fetch and adopt authn token and CA from master
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6054/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:
Line 532: * TODO(todd) should we have a single serialized PB for the authn token
+1
Line 1125: LOG.info("==> adopting token: {}", resp.getConnectResponse());
The token shoudln't be logged.
Line 1132: LOG.warn("Got more than one CA cert from leader {}: will only trust first",
Is this temporary?
--
To view, visit http://gerrit.cloudera.org:8080/6054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf172122f1c9152be9f954b26541499b714c440b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] WIP: java: fetch and adopt authn token and CA from master
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: WIP: java: fetch and adopt authn token and CA from master
......................................................................
Patch Set 2:
(3 comments)
accidentally moved this to https://gerrit.cloudera.org/#/c/6077/
http://gerrit.cloudera.org:8080/#/c/6054/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:
Line 532: * TODO(todd) should we have a single serialized PB for the authn token
> +1
done
Line 1125: LOG.info("==> adopting token: {}", resp.getConnectResponse());
> The token shoudln't be logged.
Done
Line 1132: LOG.warn("Got more than one CA cert from leader {}: will only trust first",
> Is this temporary?
yea, addressed in new rev.
--
To view, visit http://gerrit.cloudera.org:8080/6054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf172122f1c9152be9f954b26541499b714c440b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes