[GitHub] [trafficcontrol] rawlinp commented on a diff in pull request #7622: Traffic Router DNS zone calculation optimizations

["rawlinp (via GitHub)" <gi...@apache.org>]

rawlinp commented on code in PR #7622:
URL: https://github.com/apache/trafficcontrol/pull/7622#discussion_r1256486650


##########
traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/edge/CacheRegister.java:
##########
@@ -140,14 +143,42 @@ public void setDeliveryServiceMatchers(final TreeSet<DeliveryServiceMatcher> mat
 		this.deliveryServiceMatchers = matchers;
 	}
 
+	private String getRequestName(final Request request) {

Review Comment:
   `Request` has a `getHostname()` method -- does that not work here? It appears to be set for both DNS and HTTP requests, but I imagine for DNS there might be a trailing `.` to strip off before doing a map lookup.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org