You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 21:09:35 UTC

[GitHub] [camel-website] psingh587 opened a new pull request #196: Improvement upon the navbar-menu

psingh587 opened a new pull request #196: Improvement upon the navbar-menu
URL: https://github.com/apache/camel-website/pull/196
 
 
   This is regarding the merged PR #194 
     I have tried making some amendments to it 
   @zregvart  @oscerd  Please check it.
   
   This is how the navbar-menu covers the whole space on 1023px. I feel is that it is not neccessary to have it of covering the entire window here. 
   ![1023-orginal](https://user-images.githubusercontent.com/51945896/76464006-7f838e00-640a-11ea-8e6a-1db3a911ba63.png)
   
   this is my version (when width is 1023px)
   ![1023-myversion](https://user-images.githubusercontent.com/51945896/76464035-95914e80-640a-11ea-8b6e-2218ae9008dd.png)
   
   and also i think in smaller version it can cover the entire screen so here's my take on it..
   ![Mob-local](https://user-images.githubusercontent.com/51945896/76464069-a8a41e80-640a-11ea-874c-6196714e01ba.png)
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #196: Improvement upon the navbar-menu

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #196: Improvement upon the navbar-menu
URL: https://github.com/apache/camel-website/pull/196#issuecomment-598037252
 
 
   @zregvart @oscerd  
   Sir, How were these changes I made? 
   How should I go about improving them if they aren't satisfactory?
   Please guide 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart merged pull request #196: Improvement upon the navbar-menu

Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #196: Improvement upon the navbar-menu
URL: https://github.com/apache/camel-website/pull/196
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 removed a comment on issue #196: Improvement upon the navbar-menu

Posted by GitBox <gi...@apache.org>.
psingh587 removed a comment on issue #196: Improvement upon the navbar-menu
URL: https://github.com/apache/camel-website/pull/196#issuecomment-597935917
 
 
   Sir, is this okay.? if not how shall i proceed about this?
   @zregvart @oscerd 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #196: Improvement upon the navbar-menu

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #196: Improvement upon the navbar-menu
URL: https://github.com/apache/camel-website/pull/196#issuecomment-597945718
 
 
   the second commit does something like this 
   ![WhatsApp Image 2020-03-12 at 05 53 56](https://user-images.githubusercontent.com/51945896/76475738-e7939d80-6425-11ea-822b-e42d044f5e13.jpeg)
   
   
     --the color is same as what the navbar items in bigger resolution have, also the dropdown list items have underline hover property .
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] psingh587 commented on issue #196: Improvement upon the navbar-menu

Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #196: Improvement upon the navbar-menu
URL: https://github.com/apache/camel-website/pull/196#issuecomment-597935917
 
 
   Sir, is this okay.? if not how shall i proceed about this?
   @zregvart @oscerd 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-website] zregvart commented on issue #196: Improvement upon the navbar-menu

Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #196: Improvement upon the navbar-menu
URL: https://github.com/apache/camel-website/pull/196#issuecomment-598154320
 
 
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services