[jira] [Commented] (CASSANDRA-13018) Exceptions encountered calling getSeeds() breaks messaging service

["Jason Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795901#comment-15795901 ] 

Jason Brown commented on CASSANDRA-13018:
-----------------------------------------

On the whole, +1 to this patch and better code resilience. However, that whole call to {{DatabaseDescriptor#getSeeds()}} has always looked funny to me. [~brandon.williams] added this, not associated with any jira. Brandon, can you shed some light on this, especially when the log message won't tell us much (in terms of the messaging version of the peer), as the only reason why {{maxTargetVersion == NO_VERSION}} is if we failed to connect to the peer. 

tbh, I'm more in the opinion of removing the {{if (..)}} and the logged message altogether as we've seen that call to {{DatabaseDescriptor#getSeeds()}} spam the logs, hence why we limited the yaml logging in CASSANDRA-11217.

> Exceptions encountered calling getSeeds() breaks messaging service
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-13018
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13018
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>              Labels: lhf
>         Attachments: 0001-Better-handle-config-errors-during-outbound-connecti.patch
>
>
> OutboundTcpConnection.connect() calls getSeeds(). If getSeeds() throws an exception (for example, DD/Config invalid yaml error), messaging thread(s) break(s). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)