[GitHub] [arrow-adbc] kou commented on a diff in pull request #433: chore(dev/release): don't require sha256 hashes

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #433:
URL: https://github.com/apache/arrow-adbc/pull/433#discussion_r1099558347


##########
dev/release/verify-release-candidate.sh:
##########
@@ -148,9 +144,6 @@ verify_dir_artifact_signatures() {
     # basename of the artifact
     pushd $(dirname $artifact) >/dev/null
     base_artifact=$(basename $artifact)
-    if [ -f $base_artifact.sha256 ]; then
-      ${sha256_verify} $base_artifact.sha256 || exit 1
-    fi
     if [ -f $base_artifact.sha512 ]; then
       ${sha512_verify} $base_artifact.sha512 || exit 1
     fi

Review Comment:
   Can we require sha512 file?
   
   ```suggestion
       ${sha512_verify} $base_artifact.sha512 || exit 1
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org