You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/12 12:37:14 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
xiaoxiang781216 opened a new pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586
by moving the intializition code to nsh_telnetmain
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] lukegluke commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
Posted by GitBox <gi...@apache.org>.
lukegluke commented on pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-799442901
Yes you're right, I see. But as it seemed to me that previously netinit_bringup was also in nsh, so it is another problem. I didn't get deep into history of this issue and related net bringup problems, just noticed the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] lukegluke commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
Posted by GitBox <gi...@apache.org>.
lukegluke commented on pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-799393611
@acassis I had found it by git blame for that time, but I can't say it to you now.
Why not just moved netinit_bringup() code to main(int argc, FAR char *argv[]) in nsh_main.c (see code parts above)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-799388395
@lukegluke about #584 do you know which PR broke it? Maybe we could revert the offending PR until we have telnet working with it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] lukegluke commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
Posted by GitBox <gi...@apache.org>.
lukegluke commented on pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-778791865
Hi @xiaoxiang781216,
Patch fixed the build, but network not works if CONFIG_NSH_CONSOLE=n.
I suppose it is because netinit_bringup() is called only from nsh_consolemain (usbconsole/altconsole):
https://github.com/apache/incubator-nuttx-apps/blob/39a1950098b331c5a2c203431ffc26f276274863/nshlib/nsh_consolemain.c#L101-L105
that in turn is not called if no console:
https://github.com/apache/incubator-nuttx-apps/blob/f613da4f92d5ae1f719cda3f3f2ae28db3b7559b/system/nsh/nsh_main.c#L165-L168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-833691335
See the better fix here: https://github.com/apache/incubator-nuttx-apps/pull/703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-799436034
> @acassis I had found it by git blame for that time, but I can't say it to you now.
> Why not just moved netinit_bringup() code to main(int argc, FAR char *argv[]) in nsh_main.c (see code parts above)?
Because netinit_bringup() doesn't depend on nsh! You can create a standalone (a modified hello_world for example) that needs network initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #586:
URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-778172594
@lukegluke please try this path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org