You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/01/26 21:41:21 UTC

Review Request 30284: Oozie Downgrade Fails Because Upgrade Behavior Is Used

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30284/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-9339
    https://issues.apache.org/jira/browse/AMBARI-9339


Repository: ambari


Description
-------

During a downgrade, the Oozie scripts need to understand that a downgrade is occurring. This is because there is a step that happens before {{prepare-war}} where {{hadoop-lzo*.jar}} is copied to a location so that {{prepare-war}} can use it.

However, hadoop-lzo*.jar does not exist in HDP 2.2.0.0 and does exist in 2.2.1.0. 

The oozie scripts should produce an error if this file is not found and that is correct - but only for upgrade.

This is part of a larger issue where the upgrade/downgrade status needs to be available for the scripts. It currently is not.


Diffs
-----

  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 967c1e5 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py 9216afb 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 5643bda 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json PRE-CREATION 

Diff: https://reviews.apache.org/r/30284/diff/


Testing
-------

Tested a downgrade to ensure that Oozie passes.

----------------------------------------------------------------------
Total run:583
Total errors:0
Total failures:0
OK


Thanks,

Jonathan Hurley


Re: Review Request 30284: Oozie Downgrade Fails Because Upgrade Behavior Is Used

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30284/#review69683
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Jan. 26, 2015, 8:41 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30284/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 8:41 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9339
>     https://issues.apache.org/jira/browse/AMBARI-9339
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During a downgrade, the Oozie scripts need to understand that a downgrade is occurring. This is because there is a step that happens before {{prepare-war}} where {{hadoop-lzo*.jar}} is copied to a location so that {{prepare-war}} can use it.
> 
> However, hadoop-lzo*.jar does not exist in HDP 2.2.0.0 and does exist in 2.2.1.0. 
> 
> The oozie scripts should produce an error if this file is not found and that is correct - but only for upgrade.
> 
> This is part of a larger issue where the upgrade/downgrade status needs to be available for the scripts. It currently is not.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 967c1e5 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py 9216afb 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 5643bda 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30284/diff/
> 
> 
> Testing
> -------
> 
> Tested a downgrade to ensure that Oozie passes.
> 
> ----------------------------------------------------------------------
> Total run:583
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 30284: Oozie Downgrade Fails Because Upgrade Behavior Is Used

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30284/#review69679
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Jan. 26, 2015, 3:41 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30284/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 3:41 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9339
>     https://issues.apache.org/jira/browse/AMBARI-9339
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During a downgrade, the Oozie scripts need to understand that a downgrade is occurring. This is because there is a step that happens before {{prepare-war}} where {{hadoop-lzo*.jar}} is copied to a location so that {{prepare-war}} can use it.
> 
> However, hadoop-lzo*.jar does not exist in HDP 2.2.0.0 and does exist in 2.2.1.0. 
> 
> The oozie scripts should produce an error if this file is not found and that is correct - but only for upgrade.
> 
> This is part of a larger issue where the upgrade/downgrade status needs to be available for the scripts. It currently is not.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 967c1e5 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py 9216afb 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 5643bda 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30284/diff/
> 
> 
> Testing
> -------
> 
> Tested a downgrade to ensure that Oozie passes.
> 
> ----------------------------------------------------------------------
> Total run:583
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>