You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/03 02:55:54 UTC
[GitHub] [kafka] showuon opened a new pull request #8790: MINOR: Upgrade spotbugsPlugin
showuon opened a new pull request #8790:
URL: https://github.com/apache/kafka/pull/8790
Upgrade spotbugsPlugin to have clear error output to indicate where the error is.
When investigating KAFKA-10081, I found the error output of spotbugs is very poor. It doesn't even tell you where the error is, it will take a lot of time for the developers to find out where the error is, and then fix it.
https://builds.apache.org/blue/organizations/jenkins/kafka-trunk-jdk8/detail/kafka-trunk-jdk8/4596/pipeline/
Then, I found out there's a bug in spotbugsPlugin in V4.0.x, and got fixed in V4.2.x
https://github.com/spotbugs/spotbugs-gradle-plugin/issues/210
So, after upgrading to V4.2.x (I followed to the latest version V4.2.4), the output is like this:
So you can open the report file to find out the error.
I think this is very important to save the developer's time to fix the spotBug issues while developing. Thanks.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637945035
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugs and spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-638437924
One job failed for unrelated reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637945661
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #8790: MINOR: Upgrade spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637923073
@ijuma , could you review this small PR to upgrade spotbugsPlugin? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugs and spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637969959
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #8790: MINOR: Upgrade spotbugs and spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #8790:
URL: https://github.com/apache/kafka/pull/8790
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugs and spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-638340962
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637934692
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #8790: MINOR: Upgrade spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637956223
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8790: MINOR: Upgrade spotbugsPlugin
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637945559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org