You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Vincent Massol <vm...@pivolis.com> on 2004/05/10 20:20:15 UTC
RE: cvs commit: maven-plugins/artifact/xdocs changes.xml
+1 to create an <extension> tag which defaults to "jar":
<dependency>
[...]
<type>myowntype</type>
<extension>myowntypeextension</extension>
</dependency>
However that's probably for Maven 1.1.
Thanks
-Vincent
> -----Original Message-----
> From: dion_gillard@multitask.com.au
[mailto:dion_gillard@multitask.com.au]
> Sent: 11 May 2004 02:03
> To: Maven Developers List
> Subject: Re: cvs commit: maven-plugins/artifact/xdocs changes.xml
>
> brett@apache.org wrote on 11/05/2004 09:36:35 AM:
>
> > brett 2004/05/10 16:36:35
> >
> > Modified: artifact/src/main/org/apache/maven/artifact/deployer
> > DefaultArtifactDeployer.java
> > artifact/xdocs changes.xml
> > Log:
> > PR: MPUBERJAR-5
> > give uberjar type a jar extension
> >
> > Revision Changes Path
> > 1.18 +5 -1 maven-
> >
>
plugins/artifact/src/main/org/apache/maven/artifact/deployer/DefaultArti
fa
> ctDeployer.
> > java
> >
> > Index: DefaultArtifactDeployer.java
> >
===================================================================
> > RCS file: /home/cvs/maven-
> >
>
plugins/artifact/src/main/org/apache/maven/artifact/deployer/DefaultArti
fa
> ctDeployer.
> > java,v
> > retrieving revision 1.17
> > retrieving revision 1.18
> > diff -u -r1.17 -r1.18
> > --- DefaultArtifactDeployer.java 2 May 2004 15:04:34 -0000
1.17
> > +++ DefaultArtifactDeployer.java 10 May 2004 23:36:34 -0000
1.18
> > @@ -513,6 +513,10 @@
> > {
> > return "jar";
> > }
> > + else if (type.equals("uberjar"))
> > + {
> > + return "jar";
> > + }
> > return type;
> > }
> > }
>
> I'd much rather the artifact code externalised the mapping from type
to
> extension. Otherwise it will become a place of continual churn.
> --
> dIon Gillard, Multitask Consulting
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org