[GitHub] [beam] yixiaoshen commented on pull request #22966: [#22478]: Add read_time support to Google Firestore connector

[GitBox <gi...@apache.org>]

yixiaoshen commented on PR #22966:
URL: https://github.com/apache/beam/pull/22966#issuecomment-1232258702

   Note that FirestoreV1IT never ran before because the test code expected 2 environment variables that are not set in the tests environments. This PR also changed FirestoreV1IT code so that it can run without requiring the env vars. I've added coverage for consistent reads in FirestoreV1IT and tested it in a private GCP project to verify the correctness of the changes. However, I have to disable the test in PostCommit because as of now Firestore and Datastore database cannot coexist in the same GCP project and the test project already runs Datastore IT tests. I will need to defer the enablement of FirestoreV1IT in a later PR which requires setting up a new test project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org