You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zuotingbing <gi...@git.apache.org> on 2017/07/13 06:20:34 UTC
[GitHub] spark pull request #18619: [SPARK-21397][BUILD]Maven shade plugin adding dep...
GitHub user zuotingbing opened a pull request:
https://github.com/apache/spark/pull/18619
[SPARK-21397][BUILD]Maven shade plugin adding dependency-reduced-pom.xml to …
…base directory
## What changes were proposed in this pull request?
1. run `./build/mvn -DskipTests clean package` and we get many files 'dependency-reduced-pom.xml'
under the source directory
2. run `./build/mvn clean`, the files `dependency-reduced-pom.xml` can not be cleaned.
So i suggest to specify dependencyReducedPomLocation to 'target/' to store these files.
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuotingbing/spark SPARK-21397
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18619.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18619
----
commit 3ad9e3e37edb2e85387af1239d36b8b56c3e2ce5
Author: zuotingbing <zu...@zte.com.cn>
Date: 2017-07-13T06:14:04Z
[SPARK-21397]Maven shade plugin adding dependency-reduced-pom.xml to base directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18619: [SPARK-21397][BUILD]Maven shade plugin adding dependency...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18619
I like the idea, but see this note: https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#dependencyReducedPomLocation . I'm not clear whether this has side-effects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18619: [SPARK-21397][BUILD]Maven shade plugin adding dependency...
Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/18619
@srowen Thanks for your time. I am not sure the open issue, which is mentioned in the note, whether has bean resolved. as the note said
> setting a value for this parameter with a directory other than ${basedir} will change the value of ${basedir}
,but after running `mvn checkstyle:check` , i get the right path of `${basedir}/target/checkstyle-output.xml`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18619: [SPARK-21397][BUILD]Maven shade plugin adding dependency...
Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/18619
Yes this PR is a trivial Improvement for me. i will closed it if this has side-effects exactly. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18619: [SPARK-21397][BUILD]Maven shade plugin adding dependency...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18619
Meaning I think you'd have to run the release process to verify the artifacts still work, because it's the process that uses shading
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18619: [SPARK-21397][BUILD]Maven shade plugin adding dep...
Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing closed the pull request at:
https://github.com/apache/spark/pull/18619
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18619: [SPARK-21397][BUILD]Maven shade plugin adding dependency...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18619
That's not the problem this would create -- it changes basedir after execution of the shade plugin, so it might affect things like the release build. Is it really a problem? gitignore already ignores these files, even though they're a little annoying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18619: [SPARK-21397][BUILD]Maven shade plugin adding dependency...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18619
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18619: [SPARK-21397][BUILD]Maven shade plugin adding dependency...
Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/18619
I just use `mvn checkstyle:check` ,which contains output files with `basedir`, to check whether the `basedir` is correct with this PR.
Could you please specify the affect exactly as you said? what is your mean about release build? or does it the output package is not right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org