You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by lh...@apache.org on 2023/10/17 12:46:34 UTC
[pulsar] branch branch-3.0 updated (d7ca04bf5e9 -> d35618a6ddb)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a change to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/pulsar.git
from d7ca04bf5e9 [feat][sql] Support UUID for json and avro (#21267)
new 215f421041f [fix][test] Fix some resource leaks in compaction tests (#21374)
new d35618a6ddb [fix][test] Fix resource leaks with Pulsar Functions tests (#21378)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java | 2 ++
.../org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java | 2 +-
.../apache/pulsar/functions/worker/PulsarFunctionE2ESecurityTest.java | 1 -
.../org/apache/pulsar/functions/worker/PulsarFunctionPublishTest.java | 1 -
.../org/apache/pulsar/functions/worker/PulsarWorkerAssignmentTest.java | 1 -
.../src/test/java/org/apache/pulsar/io/AbstractPulsarE2ETest.java | 1 -
.../src/test/java/org/apache/pulsar/io/PulsarFunctionAdminTest.java | 1 -
7 files changed, 3 insertions(+), 6 deletions(-)
[pulsar] 01/02: [fix][test] Fix some resource leaks in compaction tests (#21374)
Posted by lh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 215f421041fb47da7e9406b65108dec9154f60c0
Author: Lari Hotari <lh...@users.noreply.github.com>
AuthorDate: Tue Oct 17 13:17:58 2023 +0300
[fix][test] Fix some resource leaks in compaction tests (#21374)
(cherry picked from commit e6cd11fb49f2d8f3376f2218e60f8c5909f66348)
# Conflicts:
# pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java
---
.../src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java | 2 ++
.../org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java
index 957671b7f8d..8524eb27aac 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactedTopicTest.java
@@ -164,6 +164,7 @@ public class CompactedTopicTest extends MockedPulsarServiceBaseTest {
@Test
public void testEntryLookup() throws Exception {
+ @Cleanup
BookKeeper bk = pulsar.getBookKeeperClientFactory().create(
this.conf, null, null, Optional.empty(), null);
@@ -219,6 +220,7 @@ public class CompactedTopicTest extends MockedPulsarServiceBaseTest {
@Test
public void testCleanupOldCompactedTopicLedger() throws Exception {
+ @Cleanup
BookKeeper bk = pulsar.getBookKeeperClientFactory().create(
this.conf, null, null, Optional.empty(), null);
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java
index e4f0750a981..09c3ebe4193 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java
@@ -168,7 +168,7 @@ public class ServiceUnitStateCompactionTest extends MockedPulsarServiceBaseTest
@Override
public void cleanup() throws Exception {
super.internalCleanup();
-
+ bk.close();
if (compactionScheduler != null) {
compactionScheduler.shutdownNow();
}
[pulsar] 02/02: [fix][test] Fix resource leaks with Pulsar Functions tests (#21378)
Posted by lh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit d35618a6ddbb6fe0bc6babb17463beef70339612
Author: Lari Hotari <lh...@users.noreply.github.com>
AuthorDate: Tue Oct 17 15:34:16 2023 +0300
[fix][test] Fix resource leaks with Pulsar Functions tests (#21378)
(cherry picked from commit ffc083b5ea9da998c35161b9dcfbfb6e38e3917e)
---
.../apache/pulsar/functions/worker/PulsarFunctionE2ESecurityTest.java | 1 -
.../org/apache/pulsar/functions/worker/PulsarFunctionPublishTest.java | 1 -
.../org/apache/pulsar/functions/worker/PulsarWorkerAssignmentTest.java | 1 -
.../src/test/java/org/apache/pulsar/io/AbstractPulsarE2ETest.java | 1 -
.../src/test/java/org/apache/pulsar/io/PulsarFunctionAdminTest.java | 1 -
5 files changed, 5 deletions(-)
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionE2ESecurityTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionE2ESecurityTest.java
index 714c9d72699..107aedd0766 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionE2ESecurityTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionE2ESecurityTest.java
@@ -268,7 +268,6 @@ public class PulsarFunctionE2ESecurityTest {
workerConfig.setAuthorizationProvider(config.getAuthorizationProvider());
PulsarWorkerService workerService = new PulsarWorkerService();
- workerService.init(workerConfig, null, false);
return workerService;
}
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionPublishTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionPublishTest.java
index 95923586fe2..6fa7172773c 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionPublishTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionPublishTest.java
@@ -263,7 +263,6 @@ public class PulsarFunctionPublishTest {
workerConfig.setAuthorizationEnabled(true);
PulsarWorkerService workerService = new PulsarWorkerService();
- workerService.init(workerConfig, null, false);
return workerService;
}
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarWorkerAssignmentTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarWorkerAssignmentTest.java
index 0821974bea5..6226fa90488 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarWorkerAssignmentTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarWorkerAssignmentTest.java
@@ -174,7 +174,6 @@ public class PulsarWorkerAssignmentTest {
workerConfig.setTopicCompactionFrequencySec(1);
PulsarWorkerService workerService = new PulsarWorkerService();
- workerService.init(workerConfig, null, false);
return workerService;
}
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/io/AbstractPulsarE2ETest.java b/pulsar-broker/src/test/java/org/apache/pulsar/io/AbstractPulsarE2ETest.java
index 9991e9f1b70..19de771a568 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/io/AbstractPulsarE2ETest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/io/AbstractPulsarE2ETest.java
@@ -301,7 +301,6 @@ public abstract class AbstractPulsarE2ETest {
workerConfig.setAuthorizationEnabled(true);
PulsarWorkerService workerService = new PulsarWorkerService();
- workerService.init(workerConfig, null, false);
return workerService;
}
}
diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionAdminTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionAdminTest.java
index 16218f6ce64..ec17382062c 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionAdminTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionAdminTest.java
@@ -207,7 +207,6 @@ public class PulsarFunctionAdminTest {
workerConfig.setTlsTrustCertsFilePath(TLS_CLIENT_CERT_FILE_PATH);
PulsarWorkerService workerService = new PulsarWorkerService();
- workerService.init(workerConfig, null, false);
return workerService;
}
}