You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by "LiJie20190102 (via GitHub)" <gi...@apache.org> on 2023/10/18 14:11:15 UTC

[PR] BIGTOP-4025:Improve the relevant conf directory for flink rpm build scripts [bigtop]

LiJie20190102 opened a new pull request, #1198:
URL: https://github.com/apache/bigtop/pull/1198

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
   -->
   
   ### Description of PR
   Improve the relevant conf directory for Flink rpm build scripts:
   1.remove redundant parameter passing
   2.Improve the default conf directory for Hadoop and Flink
   
   ### How was this patch tested?
   Build Flink rpm package and install Flink service
   
   ### For code changes:
   
   - [1 ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
   - [1] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] BIGTOP-4025:Improve the relevant conf directory for flink rpm build scripts [bigtop]

Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.

LiJie20190102 commented on PR #1198:
URL: https://github.com/apache/bigtop/pull/1198#issuecomment-1773604829

   @sekikn Please help me review the code，thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] BIGTOP-4025:Improve the relevant conf directory for flink rpm build scripts [bigtop]

Posted by "sekikn (via GitHub)" <gi...@apache.org>.

sekikn merged PR #1198:
URL: https://github.com/apache/bigtop/pull/1198


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] BIGTOP-4025:Improve the relevant conf directory for flink rpm build scripts [bigtop]

Posted by "sekikn (via GitHub)" <gi...@apache.org>.

sekikn commented on PR #1198:
URL: https://github.com/apache/bigtop/pull/1198#issuecomment-1774125088

   +1, thank you for your contribution @LiJie20190102.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org