Re: [PR] [KafkaIO] Add `with_gcp_adc` and `num_partitions` options to Kafka SchemaTransforms and YAML [beam]

["sjvanrossum (via GitHub)" <gi...@apache.org>]

sjvanrossum commented on code in PR #40181:
URL: https://github.com/apache/beam/pull/40181#discussion_r4165730871


##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformConfiguration.java:
##########
@@ -198,6 +198,21 @@ public static Builder builder() {
   @Nullable
   public abstract Boolean getRedistributeByRecordKey();
 
+  @SchemaFieldDescription(
+      "Whether to use Google Cloud Platform Application Default Credentials (ADC) for"
+          + " authenticating with a Google Managed Kafka cluster.")
+  @SchemaFieldNumber("17")
+  @Nullable
+  public abstract Boolean getWithGcpAdc();

Review Comment:
   SGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org