[jira] [Commented] (YARN-4340) Add "list" API to reservation system

["Wangda Tan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116599#comment-15116599 ] 

Wangda Tan commented on YARN-4340:
----------------------------------

Thanks [~seanpo03],
Patch looks generally good to me, few minor comments:

1) Duplicated suppress warnings:
{code}
  @SuppressWarnings("unchecked")
  @Override
  @SuppressWarnings("unchecked")
  public SignalContainerResponse signalContainer(
{code}

2) Indent issue:
{code}
  @Override
    public Set<ReservationAllocation> getReservation
{code}

And patch needs rebase to latest trunk.

I hope to get +1 from someone who is more familiar with reservation system before commit it.



> Add "list" API to reservation system
> ------------------------------------
>
>                 Key: YARN-4340
>                 URL: https://issues.apache.org/jira/browse/YARN-4340
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, fairscheduler, resourcemanager
>            Reporter: Carlo Curino
>            Assignee: Sean Po
>         Attachments: YARN-4340.v1.patch, YARN-4340.v10.patch, YARN-4340.v2.patch, YARN-4340.v3.patch, YARN-4340.v4.patch, YARN-4340.v5.patch, YARN-4340.v6.patch, YARN-4340.v7.patch, YARN-4340.v8.patch, YARN-4340.v9.patch
>
>
> This JIRA tracks changes to the APIs of the reservation system, and enables 
> querying the reservation system on which reservation exists by "time-range, reservation-id".
> YARN-4420 has a dependency on this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)