You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/13 02:28:29 UTC
[GitHub] [spark] LuciferYang edited a comment on pull request #35493: [SPAPRK-38192][CORE][TESTS] Use `try-with-resources` in `Level/RocksDBSuite.java`
LuciferYang edited a comment on pull request #35493:
URL: https://github.com/apache/spark/pull/35493#issuecomment-1037682432
@dongjoon-hyun Thank you for your guidance
At present, for `RocksDBSuite`, I can reproduce the issue stably, while for `LevelDBSuite`, I can only infer from the principle that it should have similar issue with `RocksDBSuite`.
Therefore, if the PR description focuses on `LevelDBSuite`, I can only speculate that it has issue in theory, and I can't provide the reproduction ways of `LevelDBSuite` for the time being.
Or should I change this pr back to the fix only for `RocksDBSuite`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org