You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/20 04:59:25 UTC

[GitHub] [airflow] potiuk opened a new pull request #11670: Introduced deterministic order in connection export

potiuk opened a new pull request #11670:
URL: https://github.com/apache/airflow/pull/11670


   The tests for connection export failed when CLI tests are
   run in isolation. The problem was with non-deterministic
   sequence of returned rows from connection export query.
   
   Rather than fixing the test to accept the non-deterministic
   sequence, it is better idea to return them always in the
   connection_id order. This does not change functionality and
   is backwards compatible, but at the same time it gives stability
   in the export, which might be important if someone uses export
   to determine for example if some connections were added/removed.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11670: Introduced deterministic order in connection export

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11670:
URL: https://github.com/apache/airflow/pull/11670#issuecomment-712603194






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #11670: Introduced deterministic order in connection export

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11670:
URL: https://github.com/apache/airflow/pull/11670


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #11670: Introduced deterministic order in connection export

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11670:
URL: https://github.com/apache/airflow/pull/11670#issuecomment-712589459


   Found during #11659 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #11670: Introduced deterministic order in connection export

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11670:
URL: https://github.com/apache/airflow/pull/11670#issuecomment-712621337


   random Exit 137 failure, but looks good


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed pull request #11670: Introduced deterministic order in connection export

Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #11670:
URL: https://github.com/apache/airflow/pull/11670


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org