You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 02:39:23 UTC
[GitHub] [arrow] domoritz opened a new pull request #10360: [JS] Document browser support
domoritz opened a new pull request #10360:
URL: https://github.com/apache/arrow/pull/10360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10360: ARROW-12808: [JS] Document browser support
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10360:
URL: https://github.com/apache/arrow/pull/10360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10360: ARROW-12808: [JS] Document browser support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10360:
URL: https://github.com/apache/arrow/pull/10360#issuecomment-844641209
https://issues.apache.org/jira/browse/ARROW-12808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] TheNeuralBit commented on a change in pull request #10360: ARROW-12808: [JS] Document browser support
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #10360:
URL: https://github.com/apache/arrow/pull/10360#discussion_r637422974
##########
File path: js/README.md
##########
@@ -200,6 +200,13 @@ The JS community is a diverse group with a varied list of target environments an
If you think we missed a compilation target and it's a blocker for adoption, please open an issue.
+### Supported Browsers and Platforms
+
+The bundles we compile support moderns browser released in the last 5 years. This includes supported versions of
+Firefox, Chrome, Edge, and Safari. We also support maintained versions of Node.
+We do not actively support Internet Explorer.
+Apache Arrow also works on [supported versions of Node](https://nodejs.org/en/about/releases/).
+
Review comment:
nit: this mentions Node twice.
```suggestion
### Supported Browsers and Platforms
The bundles we compile support moderns browser released in the last 5 years. This includes supported versions of
Firefox, Chrome, Edge, and Safari. We do not actively support Internet Explorer.
Apache Arrow also works on [maintained versions of Node](https://nodejs.org/en/about/releases/).
```
Should we identify [Arrow.dom](http://arrow.apache.org/docs/js/modules/arrow_dom.html) for browsers vs [Arrow.node](http://arrow.apache.org/docs/js/modules/arrow_node.html) for node?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #10360: ARROW-12808: [JS] Document browser support
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10360:
URL: https://github.com/apache/arrow/pull/10360#discussion_r637424939
##########
File path: js/README.md
##########
@@ -200,6 +200,13 @@ The JS community is a diverse group with a varied list of target environments an
If you think we missed a compilation target and it's a blocker for adoption, please open an issue.
+### Supported Browsers and Platforms
+
+The bundles we compile support moderns browser released in the last 5 years. This includes supported versions of
+Firefox, Chrome, Edge, and Safari. We also support maintained versions of Node.
+We do not actively support Internet Explorer.
+Apache Arrow also works on [supported versions of Node](https://nodejs.org/en/about/releases/).
+
Review comment:
Good catch.
I think we should explain Arrow.dom and Arrow.node in the docs rather than putting too much into the readme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #10360: ARROW-12808: [JS] Document browser support
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10360:
URL: https://github.com/apache/arrow/pull/10360#issuecomment-844643087
Merge after https://github.com/apache/arrow/pull/10340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10360: [JS] Document browser support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10360:
URL: https://github.com/apache/arrow/pull/10360#issuecomment-844639263
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org