[GitHub] [hbase] anoopsjohn commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

[GitBox <gi...@apache.org>]

anoopsjohn commented on a change in pull request #1825:
URL: https://github.com/apache/hbase/pull/1825#discussion_r433601716



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##########
@@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile, CancelableProgressable reporter) throws
         String encodedRegionNameAsStr = Bytes.toString(region);
         lastFlushedSequenceId = lastFlushedSequenceIds.get(encodedRegionNameAsStr);
         if (lastFlushedSequenceId == null) {
-          if (sequenceIdChecker != null) {
-            RegionStoreSequenceIds ids = sequenceIdChecker.getLastSequenceId(region);
-            Map<byte[], Long> maxSeqIdInStores = new TreeMap<>(Bytes.BYTES_COMPARATOR);
-            for (StoreSequenceId storeSeqId : ids.getStoreSequenceIdList()) {
-              maxSeqIdInStores.put(storeSeqId.getFamilyName().toByteArray(),
-                storeSeqId.getSequenceId());
+          if (!(isRegionDirPresentUnderRoot(entry.getKey().getTableName(), encodedRegionNameAsStr))) {
+            // The region directory itself is not present in the WAL FS. This indicates that

Review comment:
       Oh ya..  Wrong comments.. I need to change..  We check the data FS only to know whether this is still a valid region or not.  WAL fs might not have the dir unless a wal split happened (in 1.x). From 2.x the WAL FS will always have the region dir once it is 1st opened.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org