[GitHub] [spark] sarutak commented on a change in pull request #33014: [SPARK-35728][SQL][TESTS] Check multiply/divide of day-time intervals of any fields by numeric

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #33014:
URL: https://github.com/apache/spark/pull/33014#discussion_r655911249



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/IntervalExpressionsSuite.scala
##########
@@ -373,7 +371,9 @@ class IntervalExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
       (Duration.ofDays(9999), 0.0001d) -> Duration.ofDays(9999).dividedBy(10000),
       (Duration.ofDays(9999), BigDecimal(0.0001)) -> Duration.ofDays(9999).dividedBy(10000)
     ).foreach { case ((duration, num), expected) =>
-      checkEvaluation(MultiplyDTInterval(Literal(duration), Literal(num)), expected)
+      DataTypeTestUtils.dayTimeIntervalTypes.foreach { dt =>
+        checkEvaluation(MultiplyDTInterval(Literal(duration, dt), Literal(num)), expected)

Review comment:
       Let's remove the two occurrence of the following comment.
   
   ```
   // TODO(SPARK-35728): Check multiply/divide of day-time intervals of any fields by numeric
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org