You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "Mark Robert Miller (Jira)" <ji...@apache.org> on 2021/11/03 11:51:00 UTC

[jira] [Resolved] (SOLR-15551) Do not eagerly fill stack traces with ObjectReleaseTracker

     [ https://issues.apache.org/jira/browse/SOLR-15551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Robert Miller resolved SOLR-15551.
---------------------------------------
    Resolution: Won't Fix

Given some other changes in how this works with executors, won't do.

> Do not eagerly fill stack traces with ObjectReleaseTracker
> ----------------------------------------------------------
>
>                 Key: SOLR-15551
>                 URL: https://issues.apache.org/jira/browse/SOLR-15551
>             Project: Solr
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Mark Robert Miller
>            Priority: Minor
>
> Filling stack traces is really slow and so should not be eagerly done on every ObjectReleaseTracker#track.
> A much faster way to get a decent perf stack is the stack trace walker API & not necessarily walking the whole trace.
> This only fastest when everything must almost always happen and happen inline in a thread.
> If a different thread is filling the trace than the one capturing it, or if you are only filling after a failure in exceptional cases, the fastest thing to do is simple store a thrown exception  and only trigger the fill when/if needed at that point.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org