You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bubelbub <gi...@git.apache.org> on 2017/07/21 22:21:34 UTC
[GitHub] cordova-plugin-device pull request #67: Fixes the NPM build and much more th...
GitHub user Bubelbub opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/67
Fixes the NPM build and much more things [NPM 5]
👍
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DDTChen/cordova-plugin-device master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit 886a04e6de424b2e2a7a2602af9ab58884b13f1e
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T03:32:09Z
build error test
commit cef481d50ec5478a63fad16692ccd399d21bf881
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T03:50:10Z
add node version for android test
commit 55e664571010eeedf80694a843b13e08c934b1a0
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T03:55:19Z
try set nodejs env
commit 3b9a4f0f834bd3b5ae7fdbe3e613123244a9f43d
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T04:02:53Z
install nvm and node
commit 6b535afb623cb1a4422c1fe3bb3af7077cc41b23
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T05:43:18Z
fix install npm
commit de1d82564c26a887cc31908772dbede86b81bcb0
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T05:48:39Z
skip SAUCE_LAB test
commit 78a69b70a43cddc6f754071a53913bd8f814dd78
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T05:54:57Z
fix about 4.4
commit b72cbd1bc7e1f52101d365e06c063c038ddb768d
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T05:58:11Z
fix android error
commit 79f76843bcf67ca03909fa7b1cb1c50f089d405e
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T07:08:12Z
run cordova-paramedic
commit c120aa6a22645c5736f694f476046569cda4943c
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T07:38:35Z
fix create android avd
commit ca35f503cf085edbc0fb5f9743b258f4bf3ca7fc
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T07:47:37Z
fix create android avd
commit b0965e2a5cc7fca2748a7d67e1b311962730043e
Author: DDTChen <dd...@gmail.com>
Date: 2017-07-21T08:04:51Z
fix create android avd
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device issue #67: Fixes the NPM build and much more things [N...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/67
I see lots of problems with this PR:
1. The travis build fails, for starters.
2. Why eliminate sauce labs testing? That is a core component of the end-to-end testing for plugins! Without that we're flying blind.
3. Setting cordova-paramedic as a dependency of the plugin, when it is only used for testing, would be bad, as then all users of the plugin would be pulling in paramedic, which is purely a testing tool.
What specifically in these changes "fixes" stuff? And how do these changes support npm5 better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org