You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/12 06:45:08 UTC

[I] [Studio][Bug] Apache typed Topic writes omit the Broker message.type attribute [rocketmq-dashboard]

Aias00 opened a new issue, #1982:
URL: https://github.com/apache/rocketmq-dashboard/issues/1982

   ### Track
   
   RocketMQ Studio Track 1 / META-01 typed Topic management.
   
   ### Problem
   
   The Studio Topic create/update APIs accept `NORMAL`, `FIFO`, `DELAY`, `TRANSACTION`, and `LITE`, and `RocketMQAdminClientImpl` persists the selected type in `rmq_topic.topic_type`. However, the `TopicConfig` sent to each Apache RocketMQ Broker contains no Topic attributes.
   
   RocketMQ 5.x implements strong Topic types through the `message.type` Topic attribute. The documented admin form is `-a +message.type=FIFO` (and the corresponding values for the other types). Without this attribute, the Broker creates or updates a normal Topic even though Studio reports the requested typed Topic.
   
   ### Reproduction
   
   On the current `rocketmq-studio` baseline, capture the `TopicConfig` passed to `DefaultMQAdminExt#createAndUpdateTopicConfig` while creating or updating a FIFO Topic. Its attributes are `{}` instead of `{+message.type=FIFO}`. A focused regression test reproduces this for both write paths.
   
   This is the current Studio implementation of a symptom previously reported for the old Dashboard in #247; that issue was closed as stale and does not have a Studio fix.
   
   ### Impact
   
   The control plane and its local metadata can claim that a Topic is FIFO, delayed, or transactional while the Broker enforces NORMAL semantics. Producers using RocketMQ 5.x strong type validation may then be rejected or observe behavior inconsistent with the Studio UI.
   
   ### Expected behavior
   
   - Topic creation sends `+message.type=<selected type>` to every target Broker.
   - Topic updates send the attribute when a type is explicitly supplied, while preserving the Broker value for partial updates that omit the type.
   - A regression test verifies the actual `TopicConfig` passed to the Admin client rather than only checking the local database row.
   
   ### Proposed scope
   
   Update only the Apache provider Admin path and its focused unit tests. Cloud providers already map Topic types through their own OpenAPI contracts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Bug] Apache typed Topic writes omit the Broker message.type attribute [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on issue #1982:
URL: https://github.com/apache/rocketmq-dashboard/issues/1982#issuecomment-5376888176

   Resolved in the current rocketmq-studio baseline. RocketMQAdminClientImpl applies +message.type through applyTopicType() on both createTopic and updateTopic paths; the original closed PR #1983 implementation has been absorbed by subsequent changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Bug] Apache typed Topic writes omit the Broker message.type attribute [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on issue #1982:
URL: https://github.com/apache/rocketmq-dashboard/issues/1982#issuecomment-5294056221

   Additional verification details:
   
   - Affected baseline: rocketmq-studio at eb44e159 (also reproduced before the fix on the original Issue baseline).
   - Prerequisite: an Apache RocketMQ 5.x instance reachable from Studio.
   - Steps:
     1. Select the Apache instance.
     2. Create or explicitly update a Topic with type FIFO, DELAY, TRANSACTION, or LITE.
     3. Capture the TopicConfig passed to DefaultMQAdminExt#createAndUpdateTopicConfig.
     4. Inspect TopicConfig#getAttributes().
   - Actual: the attributes map is empty, so the Broker receives no +message.type attribute while Studio stores the selected type locally.
   - Expected: the config contains +message.type=<selected type>; an update that omits type preserves the Broker type.
   - Logs/stack trace: none is produced; this is an incorrect Admin request payload, reproduced with focused unit tests that capture the submitted TopicConfig.
   
   The active fix is #1983, which covers both create and update paths and closes this Issue. The earlier duplicate implementation #2060 is closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Bug] Apache typed Topic writes omit the Broker message.type attribute [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1982:
URL: https://github.com/apache/rocketmq-dashboard/issues/1982#issuecomment-5263453817

   **Issue Evaluation**
   
   Category: `bug` | Status: **Needs Info**
   
   Thank you for reporting this issue. To proceed with verification, please provide:
   - [ ] Version/tag where this occurs
   - [ ] Steps to reproduce
   - [ ] Expected vs actual behavior
   - [ ] Relevant logs or stack traces
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Bug] Apache typed Topic writes omit the Broker message.type attribute [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #1982: [Studio][Bug] Apache typed Topic writes omit the Broker message.type attribute
URL: https://github.com/apache/rocketmq-dashboard/issues/1982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org