You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/09/03 20:28:53 UTC
[I] Desktop: a native-capability tool skipped by the offer probe is invisible in Settings (MCP page still lists it as available) [maka]
liuxiaocs7 opened a new issue, #4691:
URL: https://github.com/apache/maka/issues/4691
### Summary
#4592 makes an unrepresentable native-capability tool *survivable*: `offerableToolDescriptor` (`apps/desktop/src/main/runtime-host-native-capabilities.ts`) skips a tool whose schema can't be expressed over the Client Capability protocol and `console.warn`s it, instead of failing the whole registration. That's a strictly better trade than the total outage it replaces — but it swaps a loud failure for a **silent** one: a skipped tool simply vanishes from the offer, and the only diagnostic is a main-process console line the user never sees.
Where the user actually looks, the tool still reads as live. The Settings MCP page renders the MCP manager's snapshot directly:
- `apps/desktop/src/renderer/mcp-page.tsx:922-924` shows `status.tools.length` and lists `status.tools` by name.
- `status.tools` comes from `McpServerStatus` (`packages/core/src/mcp.ts:308`), which is populated by the MCP manager and knows nothing about the Desktop offer probe.
So a server can report "connected, N tools" in Settings while the model was handed fewer than N — the dropped tool is present in the manager snapshot but absent from the capability offer. No error, no indication which tool is missing or why.
### Impact
Correctness of the surface, not of execution — the model genuinely doesn't have the skipped tool, and calling it isn't possible, so there's no wrong-result risk. But a user debugging "why won't the model use tool X" gets no signal from the UI, and the count in Settings actively contradicts what's available. Common triggers are ordinary MCP output: a JSON Schema keyword outside the protocol allowlist (`prefixItems` from a pydantic `tuple[...]`, `contentEncoding` from `bytes`, `patternProperties`, `not`, `if`/`then`/`else`, `deprecated`), pending allowlist widening in #4614.
### Proposal
Thread the skipped-tool information back to a user-visible seam so Settings can show which tools were dropped and why:
- `McpServerStatus` already carries `error?: string` and `stderrTail?: string[]` — a parallel field (e.g. `unofferedTools` / `skippedTools`, name + reason) is a natural place, and `mcp-page.tsx` already renders `status.error` / `status.stderrTail`, so the row has somewhere to put it.
- The offer probe in `runtime-host-native-capabilities.ts` already knows the exact `serverId`/`name` and the decode error at skip time; the gap is purely plumbing that back to the manager/status, which currently runs on the offering side and never reaches the manager snapshot.
### Notes
- Follow-up to #4592, not a regression it introduced — before #4592 the same tool took *every* Desktop capability down with it; this issue is only about making the (now-isolated) skip visible.
- Related: #4614 (widen the protocol allowlist so fewer tools need skipping) and #4652 (aggregate-limit failures, a different failure mode of the same registration).
_Filed with Claude Code._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] Desktop: a native-capability tool skipped by the offer probe is invisible in Settings (MCP page still lists it as available) [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #4691:
URL: https://github.com/apache/maka/issues/4691#issuecomment-5531717803
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] Desktop: a native-capability tool skipped by the offer probe is invisible in Settings (MCP page still lists it as available) [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #4691:
URL: https://github.com/apache/maka/issues/4691#issuecomment-5535062604
Closing as superseded. #4490 (merged) reworked this whole path: unrepresentable tools are skipped with a structured per-tool diagnostic surfaced through a provider `onDiagnostic` callback (wired to the main-process diagnostic log), replacing the raw `console.warn` this issue was written against, and it also handles the aggregate limits. The specific code cited here (`offerableToolDescriptor`, the `console.warn`) no longer exists on main.
The narrow remainder — surfacing a skipped tool in the Settings MCP page (`mcp-page.tsx` still renders the manager's `status.tools`) rather than only in the diagnostic log — can be refiled against the new code if it's still wanted. Closing this stale version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] Desktop: a native-capability tool skipped by the offer probe is invisible in Settings (MCP page still lists it as available) [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 closed issue #4691: Desktop: a native-capability tool skipped by the offer probe is invisible in Settings (MCP page still lists it as available)
URL: https://github.com/apache/maka/issues/4691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org