You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Ted Malaska <te...@cloudera.com> on 2012/09/06 18:05:06 UTC
Review Request: Replace object descriptor with detailed component type plus
name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6944/
-----------------------------------------------------------
Review request for Flume.
Description
-------
In the existing code when calling toString of a channel, sink, or source will output something like the following
org.apache.flume.channel.MemoryChannel@594ab51b
I over rided the toString method is the abstract classes of channel, sink, and source to output something more meaningful like the following
org.somthing.Channel {name:bob}
org.somthing.Sink {name:bob, channel:bob}
org.somthing.Source {name:bob, state:IDLE}
This addresses bug FLUME-1480.
https://issues.apache.org/jira/browse/FLUME-1480
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java 352bf08
flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java 7ecc1c9
flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java 5eeb687
Diff: https://reviews.apache.org/r/6944/diff/
Testing
-------
Thanks,
Ted Malaska
Re: Review Request: Replace object descriptor with detailed component type
plus name
Posted by Ted Malaska <te...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6944/
-----------------------------------------------------------
(Updated Sept. 10, 2012, 6:28 p.m.)
Review request for Flume.
Changes
-------
Removed spaces from patch
Description
-------
In the existing code when calling toString of a channel, sink, or source will output something like the following
org.apache.flume.channel.MemoryChannel@594ab51b
I over rided the toString method is the abstract classes of channel, sink, and source to output something more meaningful like the following
org.somthing.Channel {name:bob}
org.somthing.Sink {name:bob, channel:bob}
org.somthing.Source {name:bob, state:IDLE}
This addresses bug FLUME-1480.
https://issues.apache.org/jira/browse/FLUME-1480
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java 352bf08
flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java 7ecc1c9
flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java 5eeb687
Diff: https://reviews.apache.org/r/6944/diff/
Testing
-------
Thanks,
Ted Malaska
Re: Review Request: Replace object descriptor with detailed component type
plus name
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6944/#review11113
-----------------------------------------------------------
This looks great! The review tool shows extra whitespace in red. Eclipse can automatically remove that for you. I created a "cleanup" profile which has on "Remove trailing white spaces on all lines" selected. You can get to that by right clicking on the code then going to Source and then Cleanup.
- Brock Noland
On Sept. 6, 2012, 4:05 p.m., Ted Malaska wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6944/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2012, 4:05 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> In the existing code when calling toString of a channel, sink, or source will output something like the following
>
> org.apache.flume.channel.MemoryChannel@594ab51b
>
> I over rided the toString method is the abstract classes of channel, sink, and source to output something more meaningful like the following
>
> org.somthing.Channel {name:bob}
> org.somthing.Sink {name:bob, channel:bob}
> org.somthing.Source {name:bob, state:IDLE}
>
>
> This addresses bug FLUME-1480.
> https://issues.apache.org/jira/browse/FLUME-1480
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java 352bf08
> flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java 7ecc1c9
> flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java 5eeb687
>
> Diff: https://reviews.apache.org/r/6944/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ted Malaska
>
>