You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sebastien Goasguen <ru...@gmail.com> on 2015/03/30 10:25:56 UTC
Re: Review Request 21805: CLOUDSTACK-6748: Creating an instance with
user-data when network doesn't support user-data should error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21805/#review78183
-----------------------------------------------------------
Hari, since you are committer now, please check that the patch is in all required branches and mark the review as submitted.
thanks
- Sebastien Goasguen
On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21805/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:06 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, Murali Reddy, Rajani Karuturi, and Shengsheng Huang.
>
>
> Bugs: CLOUDSTACK-6748
> https://issues.apache.org/jira/browse/CLOUDSTACK-6748
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6748: Creating an instance with user-data when network doesn't support user-data should error
>
> When vm is deployed with userdata or ssh key or using password enabled template and in the default network that does not support userdata we should error the vm creation.
>
>
> Diffs
> -----
>
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/vm/UserVmManagerImpl.java cf04270
>
> Diff: https://reviews.apache.org/r/21805/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 21805: CLOUDSTACK-6748: Creating an instance with
user-data when network doesn't support user-data should error
Posted by Sebastien Goasguen <ru...@gmail.com>.
> On March 30, 2015, 8:25 a.m., Sebastien Goasguen wrote:
> > Hari, since you are committer now, please check that the patch is in all required branches and mark the review as submitted.
> > thanks
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21805/#review78183
-----------------------------------------------------------
On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21805/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:06 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, Murali Reddy, Rajani Karuturi, and Shengsheng Huang.
>
>
> Bugs: CLOUDSTACK-6748
> https://issues.apache.org/jira/browse/CLOUDSTACK-6748
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6748: Creating an instance with user-data when network doesn't support user-data should error
>
> When vm is deployed with userdata or ssh key or using password enabled template and in the default network that does not support userdata we should error the vm creation.
>
>
> Diffs
> -----
>
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 96dafe9
> server/src/com/cloud/vm/UserVmManagerImpl.java cf04270
>
> Diff: https://reviews.apache.org/r/21805/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>