[GitHub] [druid] capistrant edited a comment on issue #9224: Create new dynamic config to pause coordinator helpers when needed

[GitBox <gi...@apache.org>]

capistrant edited a comment on issue #9224: Create new dynamic config to pause coordinator helpers when needed
URL: https://github.com/apache/druid/pull/9224#issuecomment-576853727
 
 
   **Edit:** I ended up doing my best to add an integration test to flex this. Had to change some method signatures to get the helper methods that execute tasks to give up before segments were loaded, etc. But all refactoring of those helpers is compatible with existing tests (verified on local). Interested to see what others think of this test. **end edit.**
   
   Upon some further inspection. I'm not really sure what a good way to test the functionality would be. The unit tests cover serde of the dynamic config. So we should catch any regression issues with the actual configuration via testing in the future. The use of the config item is super elementary. If the boolean is set, it is set, and the conditional will not return true, thus the helpers will be skipped. And whether or not the boolean is set in the config object should be covered by the config unit tests, should it not. So maybe there is not a test to be written. 
   
   Unless we wanted to write an integration test that confirms that if you run an indexing job while coordinator is paused, even though the job completes, you can poll and see the segment doesn't load for x time. and then enable coordinator and confirm segment loads. But you don't really know if you tested the feature there or if the stars aligned and the timing just happened to work out... Or maybe a test that asserts something was logged, but I don't like lines that rely on logs. very fragile.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org