You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vihang Karajgaonkar <vi...@cloudera.com> on 2016/10/20 18:02:15 UTC
Re: Review Request 52493: HIVE-13589 : beeline support prompt for
password with '-p' option
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52493/
-----------------------------------------------------------
(Updated Oct. 20, 2016, 6:02 p.m.)
Review request for hive, cheng xu and Sergio Pena.
Changes
-------
Added review comments and made minor changes after rebasing to the latest changes.
Summary (updated)
-----------------
HIVE-13589 : beeline support prompt for password with '-p' option
Bugs: HIVE-13589
https://issues.apache.org/jira/browse/HIVE-13589
Repository: hive-git
Description (updated)
-------
HIVE-13589 : beeline support prompt for password with '-p' option
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/BeeLine.java fdbe0a2c6c37688ab511710bd43517908996f158
beeline/src/java/org/apache/hive/beeline/Commands.java 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION
Diff: https://reviews.apache.org/r/52493/diff/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 52493: HIVE-13589 : beeline support prompt for
password with '-p' option
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52493/#review153648
-----------------------------------------------------------
Ship it!
Ship It!
- cheng xu
On Oct. 22, 2016, 1:31 a.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52493/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2016, 1:31 a.m.)
>
>
> Review request for hive, cheng xu and Sergio Pena.
>
>
> Bugs: HIVE-13589
> https://issues.apache.org/jira/browse/HIVE-13589
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-13589 : beeline support prompt for password with '-p' option
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java fdbe0a2c6c37688ab511710bd43517908996f158
> beeline/src/java/org/apache/hive/beeline/Commands.java 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52493/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 52493: HIVE-13589 : beeline support prompt for
password with '-p' option
Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52493/
-----------------------------------------------------------
(Updated Oct. 21, 2016, 5:31 p.m.)
Review request for hive, cheng xu and Sergio Pena.
Changes
-------
Addressed review commands
Bugs: HIVE-13589
https://issues.apache.org/jira/browse/HIVE-13589
Repository: hive-git
Description
-------
HIVE-13589 : beeline support prompt for password with '-p' option
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/BeeLine.java fdbe0a2c6c37688ab511710bd43517908996f158
beeline/src/java/org/apache/hive/beeline/Commands.java 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION
Diff: https://reviews.apache.org/r/52493/diff/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 52493: HIVE-13589 : beeline support prompt for
password with '-p' option
Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
> On Oct. 21, 2016, 1:28 a.m., cheng xu wrote:
> > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 682
> > <https://reviews.apache.org/r/52493/diff/2/?file=1542454#file1542454line682>
> >
> > hint: perfer HIVE_VAR_PREFIX.equals(arg)
also removed unnecessary brackets which was making it hard to read.
> On Oct. 21, 2016, 1:28 a.m., cheng xu wrote:
> > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 953
> > <https://reviews.apache.org/r/52493/diff/2/?file=1542454#file1542454line953>
> >
> > Let's make it simple as following:
> > return url.indexOf('/', "jdbc:hive2://".length() < 0;
also renamed the method and made some changes to improve readability.
- Vihang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52493/#review153482
-----------------------------------------------------------
On Oct. 21, 2016, 5:31 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52493/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 5:31 p.m.)
>
>
> Review request for hive, cheng xu and Sergio Pena.
>
>
> Bugs: HIVE-13589
> https://issues.apache.org/jira/browse/HIVE-13589
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-13589 : beeline support prompt for password with '-p' option
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java fdbe0a2c6c37688ab511710bd43517908996f158
> beeline/src/java/org/apache/hive/beeline/Commands.java 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52493/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 52493: HIVE-13589 : beeline support prompt for
password with '-p' option
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52493/#review153482
-----------------------------------------------------------
Thank you for updating the patch. LGTM overall and just leave some minor comments.
beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 680)
<https://reviews.apache.org/r/52493/#comment222834>
hint: perfer HIVE_VAR_PREFIX.equals(arg)
beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 926)
<https://reviews.apache.org/r/52493/#comment222836>
2 space indent
beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 946)
<https://reviews.apache.org/r/52493/#comment222838>
Let's make it simple as following:
return url.indexOf('/', "jdbc:hive2://".length() < 0;
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java (line 48)
<https://reviews.apache.org/r/52493/#comment222840>
Please move it before Line 45.
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java (line 69)
<https://reviews.apache.org/r/52493/#comment222841>
hint: better to call "testPromptPasswordOptionAsFirst" in consist with the later one.
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java (line 243)
<https://reviews.apache.org/r/52493/#comment222839>
2 space indent
- cheng xu
On Oct. 21, 2016, 2:02 a.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52493/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 2:02 a.m.)
>
>
> Review request for hive, cheng xu and Sergio Pena.
>
>
> Bugs: HIVE-13589
> https://issues.apache.org/jira/browse/HIVE-13589
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-13589 : beeline support prompt for password with '-p' option
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java fdbe0a2c6c37688ab511710bd43517908996f158
> beeline/src/java/org/apache/hive/beeline/Commands.java 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/52493/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>