[GitHub] [arrow] dhruv9vats commented on a diff in pull request #14059: ARROW-17632: [Python][C++] Add details of where libarrow is being found during build

[GitBox <gi...@apache.org>]

dhruv9vats commented on code in PR #14059:
URL: https://github.com/apache/arrow/pull/14059#discussion_r964764651


##########
cpp/src/arrow/flight/ArrowFlightConfig.cmake.in:
##########
@@ -34,3 +34,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowFlightTargets.cmake")
 arrow_keep_backward_compatibility(ArrowFlight arrow_flight)
 
 check_required_components(ArrowFlight)
+
+arrow_show_details(arrow_flight)

Review Comment:
   If a project imports multiple components from arrow, like `ArrowFlight`, `ArrowCUDA` and so on, these messages tend to get repetitive as these all inherently the require Arrow core, and thus `arrow_show_details(arrow)` is called multiple times.



##########
python/pyarrow/src/ArrowPythonConfig.cmake.in:
##########
@@ -37,3 +37,5 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowPythonTargets.cmake")
 arrow_keep_backward_compatibility(ArrowPython arrow_python)
 
 check_required_components(ArrowPython)
+
+arrow_show_details(arrow_python)

Review Comment:
   We do this for PyArrow too, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org