[jira] [Commented] (ROCKETMQ-102) When shutdown(), the persisted offet is not the latest consumed message, which may cause repeated messages

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889527#comment-15889527 ] 

ASF GitHub Bot commented on ROCKETMQ-102:
-----------------------------------------

Github user Jaskey commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/64
  
    @zhouxinyu 
    
    Please check the updated pr.
    
    Since shutdownNow needs developer to take respond to interrupts but actually they should not care about this, so I still remain using shutdown , and after timeout , the method will return and remains the very same flow.
    
    BTW, unit test has been updated using  `AssetThat`



> When shutdown(), the persisted offet is not the latest consumed message, which may cause repeated messages
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-102
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-102
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-client
>            Reporter: Jaskey Lam
>            Assignee: Xiaorui Wang
>
> When shutdown push consumer, push consumer will shutdwon thread pool then persist offset.
> While shutdown thread pool is only stop submiting message to consume, which does not stop consuming message which exists in the the thread queue or is already being consumed.
> Which will cause repeated message very easily though user are shutdown gracefully according to the provided interface.
> A way to solve this problem is needed. Such as accpet a param that how long to wait for thread pool to terminated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)