You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/27 23:12:12 UTC
[GitHub] [spark] karenfeng opened a new pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
karenfeng opened a new pull request #34123:
URL: https://github.com/apache/spark/pull/34123
### What changes were proposed in this pull request?
Adds the `INTERNAL_ERROR` error class and the `isInternalError` API to `SparkThrowable`.
Removes existing error classes that are internal-only and replaces them with `INTERNAL_ERROR`.
### Why are the changes needed?
Makes it easy for end-users to diagnose whether an error is an internal error. If an end-user encounters an internal error, it should be reported immediately. This also limits the number of error classes, making it easy to audit. We do not need high-quality error messages for internal errors, as they should not be exposed to the end-user.
### Does this PR introduce _any_ user-facing change?
Yes; this changes the error class in master.
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928808522
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930437054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928527192
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929554062
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48196/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930346660
**[Test build #143722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143722/testReport)** for PR 34123 at commit [`4844d84`](https://github.com/apache/spark/commit/4844d84f6b7ad50e26db43a627249fd443ed69ad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928962900
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143669/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34123:
URL: https://github.com/apache/spark/pull/34123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928565883
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143661/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
karenfeng commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r718698840
##########
File path: core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java
##########
@@ -51,4 +51,6 @@ public String getErrorClass() {
public String getSqlState() {
return SparkThrowableHelper.getSqlState(errorClass);
}
+
+ public boolean isInternalError() { return SparkThrowableHelper.isInternalError(errorClass); }
Review comment:
Good catch, I forgot these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
karenfeng commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r718698840
##########
File path: core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java
##########
@@ -51,4 +51,6 @@ public String getErrorClass() {
public String getSqlState() {
return SparkThrowableHelper.getSqlState(errorClass);
}
+
+ public boolean isInternalError() { return SparkThrowableHelper.isInternalError(errorClass); }
Review comment:
Good catch, I forgot these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-931893848
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
karenfeng commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928701784
@cloud-fan, can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930798985
**[Test build #143749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143749/testReport)** for PR 34123 at commit [`4844d84`](https://github.com/apache/spark/commit/4844d84f6b7ad50e26db43a627249fd443ed69ad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930346660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928839360
**[Test build #143669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143669/testReport)** for PR 34123 at commit [`399ca10`](https://github.com/apache/spark/commit/399ca1048230c5f60b98b588b1b3b13f52375791).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928425319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929592861
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143682/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r718117074
##########
File path: core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java
##########
@@ -51,4 +51,6 @@ public String getErrorClass() {
public String getSqlState() {
return SparkThrowableHelper.getSqlState(errorClass);
}
+
+ public boolean isInternalError() { return SparkThrowableHelper.isInternalError(errorClass); }
Review comment:
do we still need it after we have the default implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930798985
**[Test build #143749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143749/testReport)** for PR 34123 at commit [`4844d84`](https://github.com/apache/spark/commit/4844d84f6b7ad50e26db43a627249fd443ed69ad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928478796
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-931012187
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143749/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
karenfeng commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928701784
@cloud-fan, can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
karenfeng commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930737982
@HyukjinKwon, it looks like the Python tests are failing; do you know why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r717518316
##########
File path: core/src/main/java/org/apache/spark/SparkThrowable.java
##########
@@ -39,4 +39,7 @@
// Portable error identifier across SQL engines
// If null, error class or SQLSTATE is not set
String getSqlState();
+
+ // True if this error is an internal error.
+ boolean isInternalError();
Review comment:
java interface can have default implementation now. Shall we use `SparkThrowableHelper.isInternalError(errorClass)` as the default implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929591359
**[Test build #143682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143682/testReport)** for PR 34123 at commit [`bafa473`](https://github.com/apache/spark/commit/bafa473bb294c6a3f20394b4ce946ea0cd4636a8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929482057
**[Test build #143682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143682/testReport)** for PR 34123 at commit [`bafa473`](https://github.com/apache/spark/commit/bafa473bb294c6a3f20394b4ce946ea0cd4636a8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928527192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
karenfeng commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r717817283
##########
File path: core/src/main/java/org/apache/spark/SparkThrowable.java
##########
@@ -39,4 +39,7 @@
// Portable error identifier across SQL engines
// If null, error class or SQLSTATE is not set
String getSqlState();
+
+ // True if this error is an internal error.
+ boolean isInternalError();
Review comment:
Oh, good to know. Just pushed a commit with default implementations for `getSqlState` and `isInternalError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928950555
**[Test build #143669 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143669/testReport)** for PR 34123 at commit [`399ca10`](https://github.com/apache/spark/commit/399ca1048230c5f60b98b588b1b3b13f52375791).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930437054
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48233/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930472441
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143722/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929554031
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48196/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930460292
**[Test build #143722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143722/testReport)** for PR 34123 at commit [`4844d84`](https://github.com/apache/spark/commit/4844d84f6b7ad50e26db43a627249fd443ed69ad).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930472441
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143722/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930385659
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48233/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-931012187
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143749/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929592861
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143682/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930346660
**[Test build #143722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143722/testReport)** for PR 34123 at commit [`4844d84`](https://github.com/apache/spark/commit/4844d84f6b7ad50e26db43a627249fd443ed69ad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930914114
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48260/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930914114
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48260/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930437054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928527192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928902404
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48181/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928808522
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930437018
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48233/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928902434
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48181/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928902434
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48181/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928563983
**[Test build #143661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143661/testReport)** for PR 34123 at commit [`399ca10`](https://github.com/apache/spark/commit/399ca1048230c5f60b98b588b1b3b13f52375791).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928527192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929510401
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48196/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929482057
**[Test build #143682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143682/testReport)** for PR 34123 at commit [`bafa473`](https://github.com/apache/spark/commit/bafa473bb294c6a3f20394b4ce946ea0cd4636a8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928878872
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48181/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928839360
**[Test build #143669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143669/testReport)** for PR 34123 at commit [`399ca10`](https://github.com/apache/spark/commit/399ca1048230c5f60b98b588b1b3b13f52375791).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928425319
**[Test build #143661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143661/testReport)** for PR 34123 at commit [`399ca10`](https://github.com/apache/spark/commit/399ca1048230c5f60b98b588b1b3b13f52375791).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928425319
**[Test build #143661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143661/testReport)** for PR 34123 at commit [`399ca10`](https://github.com/apache/spark/commit/399ca1048230c5f60b98b588b1b3b13f52375791).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r718117074
##########
File path: core/src/main/java/org/apache/spark/memory/SparkOutOfMemoryError.java
##########
@@ -51,4 +51,6 @@ public String getErrorClass() {
public String getSqlState() {
return SparkThrowableHelper.getSqlState(errorClass);
}
+
+ public boolean isInternalError() { return SparkThrowableHelper.isInternalError(errorClass); }
Review comment:
do we still need it after we have the default implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930346660
**[Test build #143722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143722/testReport)** for PR 34123 at commit [`4844d84`](https://github.com/apache/spark/commit/4844d84f6b7ad50e26db43a627249fd443ed69ad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930796452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r717518316
##########
File path: core/src/main/java/org/apache/spark/SparkThrowable.java
##########
@@ -39,4 +39,7 @@
// Portable error identifier across SQL engines
// If null, error class or SQLSTATE is not set
String getSqlState();
+
+ // True if this error is an internal error.
+ boolean isInternalError();
Review comment:
java interface can have default implementation now. Shall we use `SparkThrowableHelper.isInternalError(errorClass)` as the default implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928962900
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143669/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-931002142
**[Test build #143749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143749/testReport)** for PR 34123 at commit [`4844d84`](https://github.com/apache/spark/commit/4844d84f6b7ad50e26db43a627249fd443ed69ad).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-929554062
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48196/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930437054
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48233/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
karenfeng commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-931550573
Looks like it passed. Thanks @HyukjinKwon! Is this ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930914051
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48260/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928527117
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-928425319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
karenfeng commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r717817283
##########
File path: core/src/main/java/org/apache/spark/SparkThrowable.java
##########
@@ -39,4 +39,7 @@
// Portable error identifier across SQL engines
// If null, error class or SQLSTATE is not set
String getSqlState();
+
+ // True if this error is an internal error.
+ boolean isInternalError();
Review comment:
Oh, good to know. Just pushed a commit with default implementations for `getSqlState` and `isInternalError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34123:
URL: https://github.com/apache/spark/pull/34123#issuecomment-930825073
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48260/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org