[PR] fix(consumer): handle invalid settings form submissions [rocketmq-dashboard]

["btlqql (via GitHub)" <gi...@apache.org>]

btlqql opened a new pull request, #6723:
URL: https://github.com/apache/rocketmq-dashboard/pull/6723

   ### Which Issue(s) This PR Fixes
   
   - Fixes #6722
   
   ### Brief Description
   
   The Consumer Group Settings save button invokes `saveSettings()` without awaiting its promise. An invalid required retry field made `validateFields()` reject before the handler's existing mutation `try/catch`, leaving an unhandled rejection even though the form displayed its field error. Handle validation at that boundary, keep the dialog open, and report only unexpected validation errors. The settings request and stale-dialog guards remain in place.
   
   ### How Did You Test This Change?
   
   - Added a ConsumerPage component regression that clears the required Retry Queue Count, clicks Save, checks the field error and verifies that no settings request is sent. On the original code the focused run exited 1 with a Vitest `Unhandled Rejection` for `retryQueueNums`; it exits 0 after the fix.
   - `cd web && npm test -- --run src/pages/instance/__tests__/ConsumerPage.test.tsx` — 56 tests passed.
   - `cd web && npm run lint` — 0 errors, 10 warnings in existing unrelated files.
   - `cd web && npm run build` — TypeScript, Vite build and distribution license check passed. The first local build failed because Git for Windows converted the checked-in license text to CRLF; restoring that worktree file to the repository bytes made the build pass. The license file is not part of this PR.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits
   - [x] Test added for the validation regression
   - [x] No new source files or UI text
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(consumer): handle invalid settings form submissions [rocketmq-dashboard]

["github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>]

github-actions[bot] commented on PR #6723:
URL: https://github.com/apache/rocketmq-dashboard/pull/6723#issuecomment-6551022214

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(consumer): handle invalid settings form submissions [rocketmq-dashboard]

["github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>]

github-actions[bot] closed pull request #6723: fix(consumer): handle invalid settings form submissions
URL: https://github.com/apache/rocketmq-dashboard/pull/6723


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org