You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan McKinley (JIRA)" <ji...@apache.org> on 2011/08/15 02:49:27 UTC
[jira] [Created] (SOLR-2712) Deprecate fl=score behavior.
Deprecate fl=score behavior.
------------------------------
Key: SOLR-2712
URL: https://issues.apache.org/jira/browse/SOLR-2712
Project: Solr
Issue Type: Task
Reporter: Ryan McKinley
Fix For: 3.4, 4.0
SOLR-2657 points out that all fields show up when you request score and something becides a 'normal' field. To support the strange behavior and avoid it when uncenessary we have this:
{code:java}
if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && globs.isEmpty() ) {
_wantsAllFields = true;
}
{code}
I suggest we advertise in 3.x that expecting *fl=score* to return all fields is deprecated, and remove this bit of crazy code from 4.x
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2712) Deprecate fl=score behavior.
Posted by "Mark Miller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233390#comment-13233390 ]
Mark Miller commented on SOLR-2712:
-----------------------------------
There was something missed here. I'll fix it when I fix the multiple fl's not being treated right in distrib search - around that same code there is still logic that expects this.
> Deprecate fl=score behavior.
> ------------------------------
>
> Key: SOLR-2712
> URL: https://issues.apache.org/jira/browse/SOLR-2712
> Project: Solr
> Issue Type: Task
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 3.6, 4.0
>
>
> SOLR-2657 points out that all fields show up when you request score and something becides a 'normal' field. To support the strange behavior and avoid it when uncenessary we have this:
> {code:java}
> if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && globs.isEmpty() ) {
> _wantsAllFields = true;
> }
> {code}
> I suggest we advertise in 3.x that expecting *fl=score* to return all fields is deprecated, and remove this bit of crazy code from 4.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2712) Deprecate fl=score behavior.
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088428#comment-13088428 ]
Ryan McKinley commented on SOLR-2712:
-------------------------------------
What is the right process to deprecate this behavior in 3.x?
Is it just a note in the CHANGES.txt?
We could also try to detect the behavior and log a warning... but i'm not sure that is worth much.
> Deprecate fl=score behavior.
> ------------------------------
>
> Key: SOLR-2712
> URL: https://issues.apache.org/jira/browse/SOLR-2712
> Project: Solr
> Issue Type: Task
> Reporter: Ryan McKinley
> Fix For: 3.4, 4.0
>
>
> SOLR-2657 points out that all fields show up when you request score and something becides a 'normal' field. To support the strange behavior and avoid it when uncenessary we have this:
> {code:java}
> if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && globs.isEmpty() ) {
> _wantsAllFields = true;
> }
> {code}
> I suggest we advertise in 3.x that expecting *fl=score* to return all fields is deprecated, and remove this bit of crazy code from 4.x
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2712) Deprecate fl=score behavior.
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088297#comment-13088297 ]
David Smiley commented on SOLR-2712:
------------------------------------
+1 I just ran into this today! I was about to file a bug.
> Deprecate fl=score behavior.
> ------------------------------
>
> Key: SOLR-2712
> URL: https://issues.apache.org/jira/browse/SOLR-2712
> Project: Solr
> Issue Type: Task
> Reporter: Ryan McKinley
> Fix For: 3.4, 4.0
>
>
> SOLR-2657 points out that all fields show up when you request score and something becides a 'normal' field. To support the strange behavior and avoid it when uncenessary we have this:
> {code:java}
> if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && globs.isEmpty() ) {
> _wantsAllFields = true;
> }
> {code}
> I suggest we advertise in 3.x that expecting *fl=score* to return all fields is deprecated, and remove this bit of crazy code from 4.x
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2712) Deprecate fl=score behavior.
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085092#comment-13085092 ]
Yonik Seeley commented on SOLR-2712:
------------------------------------
+1
> Deprecate fl=score behavior.
> ------------------------------
>
> Key: SOLR-2712
> URL: https://issues.apache.org/jira/browse/SOLR-2712
> Project: Solr
> Issue Type: Task
> Reporter: Ryan McKinley
> Fix For: 3.4, 4.0
>
>
> SOLR-2657 points out that all fields show up when you request score and something becides a 'normal' field. To support the strange behavior and avoid it when uncenessary we have this:
> {code:java}
> if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && globs.isEmpty() ) {
> _wantsAllFields = true;
> }
> {code}
> I suggest we advertise in 3.x that expecting *fl=score* to return all fields is deprecated, and remove this bit of crazy code from 4.x
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2712) Deprecate fl=score behavior.
Posted by "Ryan McKinley (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved SOLR-2712.
---------------------------------
Resolution: Fixed
Assignee: Ryan McKinley
Added warning in 3.x #1298683
removed from trunk in #1298690
> Deprecate fl=score behavior.
> ------------------------------
>
> Key: SOLR-2712
> URL: https://issues.apache.org/jira/browse/SOLR-2712
> Project: Solr
> Issue Type: Task
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 3.6, 4.0
>
>
> SOLR-2657 points out that all fields show up when you request score and something becides a 'normal' field. To support the strange behavior and avoid it when uncenessary we have this:
> {code:java}
> if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && globs.isEmpty() ) {
> _wantsAllFields = true;
> }
> {code}
> I suggest we advertise in 3.x that expecting *fl=score* to return all fields is deprecated, and remove this bit of crazy code from 4.x
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2712) Deprecate fl=score behavior.
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088459#comment-13088459 ]
Yonik Seeley commented on SOLR-2712:
------------------------------------
I imagine it's a very rarely used "feature", as I don't think it's documented.
http://wiki.apache.org/solr/CommonQueryParameters#fl
A note in CHANGES in trunk may be all that's warranted?
> Deprecate fl=score behavior.
> ------------------------------
>
> Key: SOLR-2712
> URL: https://issues.apache.org/jira/browse/SOLR-2712
> Project: Solr
> Issue Type: Task
> Reporter: Ryan McKinley
> Fix For: 3.4, 4.0
>
>
> SOLR-2657 points out that all fields show up when you request score and something becides a 'normal' field. To support the strange behavior and avoid it when uncenessary we have this:
> {code:java}
> if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && globs.isEmpty() ) {
> _wantsAllFields = true;
> }
> {code}
> I suggest we advertise in 3.x that expecting *fl=score* to return all fields is deprecated, and remove this bit of crazy code from 4.x
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org