You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Fred Ji <fj...@linkedin.com> on 2016/07/22 00:22:11 UTC
Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/; 2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup; 3. update some sentences or rephrase to make description clearer.
Diffs
-----
docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
Diff: https://reviews.apache.org/r/50317/diff/
Testing
-------
Thanks,
Fred Ji
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by Fred Ji <fj...@linkedin.com>.
> On July 22, 2016, 3:39 a.m., Jagadish Venkatraman wrote:
> > docs/learn/documentation/versioned/container/samza-container.md, line 107
> > <https://reviews.apache.org/r/50317/diff/1/?file=1450702#file1450702line107>
> >
> > For consistency, we can maybe use the name broadcast-stream1 and broadcast-stream2. What do you think?
Thanks for the comments. I updated them with broadcast-stream-1 and broadcast-stream-2.
I also tested the changes and links on local Jekyll, with Navina's help. Thanks!
- Fred
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review143173
-----------------------------------------------------------
On July 22, 2016, 11:06 p.m., Fred Ji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> -----------------------------------------------------------
>
> (Updated July 22, 2016, 11:06 p.m.)
>
>
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> 1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
> 2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
> 3. update some sentences or rephrase to make description clearer.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
> docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
> docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
> docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
> docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
> docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
> docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
> docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
> docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
> docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
> docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
> docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
> docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
>
> Diff: https://reviews.apache.org/r/50317/diff/
>
>
> Testing
> -------
>
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
> ./gradlew clean build
> 2. Check if your code follows the coding conventions:
> ./gradlew checkstyleMain checkstyleTest
>
> Brought up Jekyll, built a local website out of markdown pages, and verified the changes and links on localhost server.
>
>
> Thanks,
>
> Fred Ji
>
>
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review143173
-----------------------------------------------------------
Ship it!
I'm not sure if we have a way to test updates to html documentation (basically to ensure that we don't break html formatting. Could we run a http server to host the samza web page on our local host?
Yi/Navina can provide more context.
docs/learn/documentation/versioned/container/samza-container.md (line 107)
<https://reviews.apache.org/r/50317/#comment208962>
For consistency, we can maybe use the name broadcast-stream1 and broadcast-stream2. What do you think?
- Jagadish Venkatraman
On July 22, 2016, 12:26 a.m., Fred Ji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> -----------------------------------------------------------
>
> (Updated July 22, 2016, 12:26 a.m.)
>
>
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> 1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
> 2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
> 3. update some sentences or rephrase to make description clearer.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
> docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
> docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
> docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
> docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
> docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
> docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
> docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
> docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
> docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
> docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
> docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
> docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
>
> Diff: https://reviews.apache.org/r/50317/diff/
>
>
> Testing
> -------
>
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
> ./gradlew clean build
> 2. Check if your code follows the coding conventions:
> ./gradlew checkstyleMain checkstyleTest
>
>
> Thanks,
>
> Fred Ji
>
>
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review144365
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On July 22, 2016, 11:23 p.m., Fred Ji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> -----------------------------------------------------------
>
> (Updated July 22, 2016, 11:23 p.m.)
>
>
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-978
> https://issues.apache.org/jira/browse/SAMZA-978
>
>
> Repository: samza
>
>
> Description
> -------
>
> 1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
> 2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
> 3. update some sentences or rephrase to make description clearer.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
> docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
> docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
> docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
> docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
> docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
> docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
> docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
> docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
> docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
> docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
> docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
> docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
>
> Diff: https://reviews.apache.org/r/50317/diff/
>
>
> Testing
> -------
>
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
> ./gradlew clean build
> 2. Check if your code follows the coding conventions:
> ./gradlew checkstyleMain checkstyleTest
>
> Brought up Jekyll, built a local website out of markdown pages, and verified the changes and links on localhost server.
>
>
> Thanks,
>
> Fred Ji
>
>
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by Fred Ji <fj...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/
-----------------------------------------------------------
(Updated July 22, 2016, 11:23 p.m.)
Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
Changes
-------
fixed the Bug link for the RB information. The bugs field just requires the bug number but not the whole link.
Bugs: SAMZA-978
https://issues.apache.org/jira/browse/SAMZA-978
Repository: samza
Description
-------
1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
3. update some sentences or rephrase to make description clearer.
Diffs
-----
docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
Diff: https://reviews.apache.org/r/50317/diff/
Testing
-------
Basic unit tests and checkstyleTest passed.
1. Run unit tests:
./gradlew clean build
2. Check if your code follows the coding conventions:
./gradlew checkstyleMain checkstyleTest
Brought up Jekyll, built a local website out of markdown pages, and verified the changes and links on localhost server.
Thanks,
Fred Ji
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by Fred Ji <fj...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/
-----------------------------------------------------------
(Updated July 22, 2016, 11:10 p.m.)
Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
Changes
-------
linked up with https://issues.apache.org/jira/browse/SAMZA-978
Bugs: https://issues.apache.org/jira/browse/SAMZA-978
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SAMZA-978
Repository: samza
Description
-------
1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
3. update some sentences or rephrase to make description clearer.
Diffs
-----
docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
Diff: https://reviews.apache.org/r/50317/diff/
Testing
-------
Basic unit tests and checkstyleTest passed.
1. Run unit tests:
./gradlew clean build
2. Check if your code follows the coding conventions:
./gradlew checkstyleMain checkstyleTest
Brought up Jekyll, built a local website out of markdown pages, and verified the changes and links on localhost server.
Thanks,
Fred Ji
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by Fred Ji <fj...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/
-----------------------------------------------------------
(Updated July 22, 2016, 11:06 p.m.)
Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
Changes
-------
changed global-stream to broadstream to be consistent in samza-container.md.
Tested with Jekyll.
Repository: samza
Description
-------
1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
3. update some sentences or rephrase to make description clearer.
Diffs (updated)
-----
docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
Diff: https://reviews.apache.org/r/50317/diff/
Testing (updated)
-------
Basic unit tests and checkstyleTest passed.
1. Run unit tests:
./gradlew clean build
2. Check if your code follows the coding conventions:
./gradlew checkstyleMain checkstyleTest
Brought up Jekyll, built a local website out of markdown pages, and verified the changes and links on localhost server.
Thanks,
Fred Ji
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by Fred Ji <fj...@linkedin.com>.
> On July 22, 2016, 12:37 a.m., Jake Maes wrote:
> > docs/learn/documentation/versioned/index.html, lines 48-49
> > <https://reviews.apache.org/r/50317/diff/1/?file=1450706#file1450706line48>
> >
> > I'm not sure these should be nested in the Overview page. They are critical parts of the API and we want users to be able to find them easily.
Thanks for the comments. These two are on the main list when we go to https://samza.apache.org/ (left column list including "Documentation" which is for this doc, and "Configuration", "Javadocs", and etc.), so users can find them as easily as "Hello Samza", "FAQ".
We may not want to list "Configuration" and "Javadocs" again in the table for https://samza.apache.org/learn/documentation/0.10/ as another individual sections, and also, all sections in https://samza.apache.org/learn/documentation/0.10/ are following the same format except "Configuration" and "Javadocs".
- Fred
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review143165
-----------------------------------------------------------
On July 22, 2016, 12:26 a.m., Fred Ji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> -----------------------------------------------------------
>
> (Updated July 22, 2016, 12:26 a.m.)
>
>
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> 1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
> 2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
> 3. update some sentences or rephrase to make description clearer.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
> docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
> docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
> docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
> docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
> docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
> docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
> docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
> docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
> docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
> docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
> docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
> docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
>
> Diff: https://reviews.apache.org/r/50317/diff/
>
>
> Testing
> -------
>
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
> ./gradlew clean build
> 2. Check if your code follows the coding conventions:
> ./gradlew checkstyleMain checkstyleTest
>
>
> Thanks,
>
> Fred Ji
>
>
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by Jake Maes <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review143165
-----------------------------------------------------------
docs/learn/documentation/versioned/index.html
<https://reviews.apache.org/r/50317/#comment208937>
I'm not sure these should be nested in the Overview page. They are critical parts of the API and we want users to be able to find them easily.
- Jake Maes
On July 22, 2016, 12:26 a.m., Fred Ji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> -----------------------------------------------------------
>
> (Updated July 22, 2016, 12:26 a.m.)
>
>
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> 1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
> 2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
> 3. update some sentences or rephrase to make description clearer.
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
> docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
> docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
> docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
> docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
> docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
> docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
> docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
> docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
> docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
> docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
> docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
> docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
>
> Diff: https://reviews.apache.org/r/50317/diff/
>
>
> Testing
> -------
>
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
> ./gradlew clean build
> 2. Check if your code follows the coding conventions:
> ./gradlew checkstyleMain checkstyleTest
>
>
> Thanks,
>
> Fred Ji
>
>
Re: Review Request 50317: SAMZA-978: update md files to resolve
inconsistent links, broken links and some confusing sentences
Posted by Fred Ji <fj...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/
-----------------------------------------------------------
(Updated July 22, 2016, 12:26 a.m.)
Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
Changes
-------
added tests done and added more people in the reviewers list.
Repository: samza
Description (updated)
-------
1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/;
2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup;
3. update some sentences or rephrase to make description clearer.
Diffs
-----
docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e
docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18
docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4
docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d
docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195
docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd
docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770
docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b
docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16
docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec
docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23
docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc
docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8
Diff: https://reviews.apache.org/r/50317/diff/
Testing (updated)
-------
Basic unit tests and checkstyleTest passed.
1. Run unit tests:
./gradlew clean build
2. Check if your code follows the coding conventions:
./gradlew checkstyleMain checkstyleTest
Thanks,
Fred Ji