You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Lohit Vijayarenu (JIRA)" <ji...@apache.org> on 2008/07/09 02:24:31 UTC

[jira] Created: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

dfsadmin -refreshNodes should re-read the config file.
------------------------------------------------------

                 Key: HADOOP-3720
                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
             Project: Hadoop Core
          Issue Type: Bug
          Components: dfs
    Affects Versions: 0.19.0
            Reporter: Lohit Vijayarenu


hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Attachment: HADOOP-3720-3.patch

Updated patch changes documentation a bit and includes the same in help message as well. 

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Attachment: HADOOP-3720-1.patch

Attached patch re-reads the config in refreshNodes. I tested this manually and it works

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Description: hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked.   (was: hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file when refreshNodes command is invoked. )

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613128#action_12613128 ] 

Hadoop QA commented on HADOOP-3720:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12385669/HADOOP-3720-3.patch
  against trunk revision 676069.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2847/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2847/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2847/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2847/console

This message is automatically generated.

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Status: Open  (was: Patch Available)

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch, HADOOP-3720-4.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Attachment: HADOOP-3720-2.patch

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Attachment:     (was: HADOOP-3720-2.patch)

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Assignee: Lohit Vijayarenu
      Status: Patch Available  (was: Open)

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612597#action_12612597 ] 

Raghu Angadi commented on HADOOP-3720:
--------------------------------------

+1. Looks good.

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Status: Patch Available  (was: Open)

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch, HADOOP-3720-4.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Attachment: HADOOP-3720-4.patch

The test was failing becuase it was updating conf object rather than a conf file. So, modified test to invoke refreshNodes on namenode directly passing conf object. Fixed findbug warnings. 

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch, HADOOP-3720-4.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3720:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Lohit

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch, HADOOP-3720-4.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624756#action_12624756 ] 

Hudson commented on HADOOP-3720:
--------------------------------

Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch, HADOOP-3720-4.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lohit Vijayarenu updated HADOOP-3720:
-------------------------------------

    Attachment: HADOOP-3720-2.patch

Minor modifications to patch and updated the docs about refreshNodes.

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613818#action_12613818 ] 

Hadoop QA commented on HADOOP-3720:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12386016/HADOOP-3720-4.patch
  against trunk revision 677054.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2865/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2865/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2865/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2865/console

This message is automatically generated.

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>            Assignee: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch, HADOOP-3720-4.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3720) dfsadmin -refreshNodes should re-read the config file.

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-3720:
---------------------------------

    Hadoop Flags: [Reviewed]

> dfsadmin -refreshNodes should re-read the config file.
> ------------------------------------------------------
>
>                 Key: HADOOP-3720
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3720
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>         Attachments: HADOOP-3720-1.patch, HADOOP-3720-2.patch, HADOOP-3720-3.patch
>
>
> hadoop dfsadmin -refreshNodes reads files defined by _dfs.hosts_ and _dfs.hosts.exclude_. If these values are not defined during namenode startup, then refreshNodes command assumes there are no files. So, while namenode is running, once cannot just edit the config file and add entries to these config variables and expect the namenode to read them. Namenode should re-read the config file for these variables (_dfs.hosts_ and _dfs.hosts.exclude_) when refreshNodes command is invoked. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.