You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/09/10 13:19:16 UTC
[GitHub] arina-ielchiieva commented on a change in pull request #1460:
DRILL-6732: Queries are runnable on disable plugins
arina-ielchiieva commented on a change in pull request #1460: DRILL-6732: Queries are runnable on disable plugins
URL: https://github.com/apache/drill/pull/1460#discussion_r216317897
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngineConfig.java
##########
@@ -34,6 +34,7 @@
@JsonCreator
public MockStorageEngineConfig(@JsonProperty("url") String url) {
this.url = url;
+ this.setEnabled(true);
Review comment:
This is not correct place to enable plugin config. You enable plugin after its creation, not directly in config itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services