You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2015/05/05 02:49:55 UTC

[GitHub] cordova-js pull request: check the window.cordova object a little ...

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-js/pull/109

    check the window.cordova object a little more strictly

    Bringing back good old CB-7992 and #104

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-js ripplefix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #109
    
----
commit 413c874db3e419b7f8219901bd591c8c901d2696
Author: Jesse MacFadyen <pu...@gmail.com>
Date:   2015-05-05T00:47:52Z

    check the window.cordova object a little more strictly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-js pull request: check the window.cordova object a little ...

Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:

    https://github.com/apache/cordova-js/pull/109#issuecomment-98912776
  
    :thumbsup: I can verify this fixes the Ripple break.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-js pull request: check the window.cordova object a little ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-js/pull/109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org